add github actions android builds and linux export template #538
Conversation
add concurrency on each github actions. this will cancel already running action/s if a there's new commit
.github/workflows/android_builds.yml
Outdated
| SCONS_CACHE: ${{github.workspace}}/.scons_cache/ | ||
| run: | | ||
| PATH=${GITHUB_WORKSPACE}/x86_64-godot-linux-gnu_sdk-buildroot/bin:$PATH | ||
| scons -j2 verbose=yes warnings=extra platform=android target=${{matrix.target}} arch=${{matrix.arch}} |
There was a problem hiding this comment.
The arch names used in Godot's build system are "x86_32", "x86_64", "arm32", "arm64" with some aliases to help users pick the correct name. You are currently using "x86", "x86_64", "armv7", "arm64v8" in this pull request. Ideally, the names the CI uses should be the same as what Godot uses, since these are the names the final executables will have ("armv7" becomes ex: godot.linux.editor.arm32). So please change this.
| SCONS_CACHE_LIMIT: 4096 | ||
|
|
||
|
|
||
| concurrency: |
There was a problem hiding this comment.
Inconsistent empty line amount.
|
With artifacts for all these targets, this is going to increase space usage significantly, but we'll see if it causes problems. If it does I'll probably remove builds that are less used. Why did you separate The concurrency option is a nice addition :) |
@Zylann I've noticed that you have made different matrix for single and double precision builds for linux. so I've seperated it since I'm not sure if it's needed for linux export templates as well |
rename android_builds.yml to android.yml to be consistent with other files set the name of jobs to be more readable rename linux exports artifact
set job names to be more readable rename the linux_exports artifacts
|
I don't know what happened, git doesn't seem to display the changes I've made on android.yml correctly |
Double-precision builds are in the same matrix. They aren't in separate files. They are also needed in export templates, for example if you want to export a game with large environments. However they are less often used so for now I'm not building for all platforms with it (again to limit space usage).
Usually when making PRs I amend the last commit and use |
| strategy: | ||
| matrix: | ||
| include: | ||
| ####TEPMPLATES#### |
There was a problem hiding this comment.
| ####TEPMPLATES#### | |
| ####TEMPLATES#### |
Zylann
force-pushed
the
master
branch
3 times, most recently
from
c86f994 to
208695b
Compare
|
closing this PR cause this doesn't seem to be needed for main repo |
this PR adds a build for android, including export templates and android editor for all architectures. it also adds linux exports templates for i686 and x86_64 architectures.
please note that I have added concurrency on all yml files. this will cancel already running github actions if there's a new commit, which prioritizes the new commit