Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create universal macOS build with Intel/M-series chips support. #598

Closed
wants to merge 5 commits into from
Closed

Create universal macOS build with Intel/M-series chips support. #598

wants to merge 5 commits into from

Conversation

marknefedov
Copy link
Contributor

No description provided.

Remove jobs flag, scons will use all cores automatically
@Zylann
Copy link
Owner

Zylann commented Feb 6, 2024

The build took quite a while, for now I'm suspecting that's simply because the name of the cache changed.
But also the two builds happen in serial. Maybe later something simpler would be to just add an arch parameter to the matrix and executable names (then they will build in parallel), and have another job depending on the first one, which would get both artifacts to generate the universal builds? Tbh I wonder how useful universal builds actually are for nightlies (remember this runs everytime anything is pushed to the repo), though certainly useful to grab them to make a release.

Also do release templates work as univeral builds? I wonder if Godot is actually able to be given such universal binary to export with. I never exported for Mac, but when I look in the Export window Custom Template, it wants a .zip and not a .universal. The artifact is wrapped into a zip by Github, but inside it's one file without extension, although it actually is an archive itself with two files in it. I wonder if that's the same thing Godot wants?

@marknefedov
Copy link
Contributor Author

marknefedov commented Feb 6, 2024

Maybe, I'm not sure actually, at least https://docs.godotengine.org/en/stable/contributing/development/compiling/compiling_for_macos.html#building-export-templates show how to make universal binary for templates. Probably need to compose an .app archive.

@marknefedov marknefedov marked this pull request as draft February 6, 2024 18:10
@marknefedov marknefedov closed this Feb 6, 2024
@marknefedov marknefedov deleted the macos-universal-build branch February 6, 2024 18:32
@Zylann
Copy link
Owner

Zylann commented Feb 6, 2024

I'll assume the universal build is what Godot wants, it might just be a file extension thing. The fact the doc mentions a .app and the export templates window expects .zip is confusing.

I'm still considering multi-architecture and universal builds so I'll likely integrate this to the CI at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants