Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

calling save_model_card correctly #275

Merged
merged 3 commits into from
Mar 2, 2025
Merged

calling save_model_card correctly #275

merged 3 commits into from
Mar 2, 2025

Conversation

vivkul
Copy link
Contributor

@vivkul vivkul commented Mar 2, 2025 •
edited
Loading

Previously, when num_validation_samples == 0 then save_model_card was called even if self.args.push_to_hub or final_validation was False.

@vivkul vivkul changed the title save_model_card is called only if self.args.push_to_hub is True. calling save_model_card correctly Mar 2, 2025
a-r-r-o-w
a-r-r-o-w approved these changes Mar 2, 2025
View reviewed changes
Copy link
Owner

@a-r-r-o-w a-r-r-o-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@a-r-r-o-w a-r-r-o-w merged commit c4d6c6c into a-r-r-o-w:main Mar 2, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-r-r-o-w a-r-r-o-w a-r-r-o-w approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vivkul @a-r-r-o-w