Skip to content

Refactor/class to func component #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Refactor/class to func component #44

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
1865f5a
refactor: NoPrint component
Vitao18 Nov 8, 2019
0a39b4c
refactor: PrintProvider component
Vitao18 Nov 9, 2019
3da9e0e
fix: export default PrintProvider
Vitao18 Nov 9, 2019
2162f84
fix: add missing export defaults
Vitao18 Nov 9, 2019
c9f6153
feat: split state into multiple useStates
Vitao18 Nov 12, 2019
19b46c0
fix: replace Object.assign with spread operator
Vitao18 Nov 12, 2019
888db31
fix: add current to 'printableRegistry' mutations
Vitao18 Nov 14, 2019
1656f05
NoPrint: keep component name in devtools by using named function
a-x- Nov 23, 2019
0275379
Print: keep component name in devtools by using named function
a-x- Nov 23, 2019
c58fb54
PrintProviderContext: eof
a-x- Nov 23, 2019
7aec3f1
PrintProvider: keep component name in devtools by using named function
a-x- Nov 23, 2019
b82b58d
PrintProvider: use uniq id 😳
a-x- Nov 23, 2019
3f6e270
Print: add empy array to useEffect deps
Vitao18 Nov 23, 2019
bf1ccc2
PrintProvider: move useEffects to top and fix hasSingle validation
Vitao18 Nov 23, 2019
dc5c164
PrintProvider: update deps on useEffects
Vitao18 Nov 23, 2019
21555d9
PrintProvider: move back to Object.assign to avoid additional complexity
Vitao18 Nov 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/PrintProvider.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,10 @@ const PrintProvider = props => {
printableRegistry[key]
)
);
printableRegistry.current = Object.assign({}, printableRegistry, {
printableRegistry.current = {
...printableRegistry,
[key]: undefined
});
};
if (isSingle) {
unhideAll();
}
Expand Down