Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aria label to the button for accessibility. #43

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from
Open

Add aria label to the button for accessibility. #43

wants to merge 3 commits into from

Conversation

verytwisty
Copy link
Collaborator

Having used this toggle on a site, an issue has come up in functional QA testing regarding the accessibility of the toggle switch. To address this I have added an aria-label to the toggle which changes slightly when the toggle is checked.

The Switching Mode button (e.g., Light/Dark mode toggle) does not have accessible text or an ARIA label. This makes it difficult for screen readers and assistive technologies to convey its purpose to visually impaired users, impacting WCAG 2.1 compliance

@verytwisty verytwisty self-assigned this Feb 25, 2025
gin0115
gin0115 approved these changes Feb 26, 2025
View reviewed changes
Copy link
Collaborator

@gin0115 gin0115 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me, the deprecated should be fine with any sites using it. I know the AndrewSpittle site hasnt used it yet on prod, just staging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gin0115 gin0115 gin0115 approved these changes

@nate-allen nate-allen Awaiting requested review from nate-allen

Assignees

@verytwisty verytwisty

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@verytwisty @gin0115