Skip to content

Commit 8c437be

Browse files
committed
fix(controller): re-enable some metrics disabled by mistake
1 parent 4b763c6 commit 8c437be

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

internal/controller/collector.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,15 +17,15 @@ const subsystem = "controller"
1717
var ProbeAddr = ""
1818

1919
var (
20-
imagePutInCache = prometheus.NewCounter(
20+
ImagePutInCache = prometheus.NewCounter(
2121
prometheus.CounterOpts{
2222
Namespace: kuikMetrics.Namespace,
2323
Subsystem: subsystem,
2424
Name: "image_put_in_cache_total",
2525
Help: "Number of images put in cache successfully",
2626
},
2727
)
28-
imageRemovedFromCache = prometheus.NewCounter(
28+
ImageRemovedFromCache = prometheus.NewCounter(
2929
prometheus.CounterOpts{
3030
Namespace: kuikMetrics.Namespace,
3131
Subsystem: subsystem,
@@ -59,8 +59,8 @@ var (
5959
func RegisterMetrics(client client.Client) {
6060
// Register custom metrics with the global prometheus registry
6161
metrics.Registry.MustRegister(
62-
imagePutInCache,
63-
imageRemovedFromCache,
62+
ImagePutInCache,
63+
ImageRemovedFromCache,
6464
kuikMetrics.NewInfo(subsystem),
6565
isLeader,
6666
up,

internal/controller/kuik/cachedimage_controller.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ func (r *CachedImageReconciler) Reconcile(ctx context.Context, req ctrl.Request)
139139
return ctrl.Result{}, err
140140
}
141141
r.Recorder.Eventf(&cachedImage, "Normal", "CleanedUp", "Image %s successfully removed from cache", cachedImage.Spec.SourceImage)
142-
// imageRemovedFromCache.Inc()
142+
kuikController.ImageRemovedFromCache.Inc()
143143

144144
log.Info("removing finalizer")
145145
controllerutil.RemoveFinalizer(&cachedImage, cachedImageFinalizerName)
@@ -251,7 +251,7 @@ func (r *CachedImageReconciler) Reconcile(ctx context.Context, req ctrl.Request)
251251
} else {
252252
log.Info("image cached")
253253
r.Recorder.Eventf(&cachedImage, "Normal", "Cached", "Successfully cached image %s", cachedImage.Spec.SourceImage)
254-
// imagePutInCache.Inc()
254+
kuikController.ImagePutInCache.Inc()
255255
}
256256
} else {
257257
log.Info("image already present in cache, ignoring")

0 commit comments

Comments
 (0)