Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce ssort in CI #438

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Introduce ssort in CI #438

merged 1 commit into from
Jan 26, 2024

Conversation

mristin
Copy link
Contributor

@mristin mristin commented Jan 26, 2024

We use ssort to sort the definitions in the source files in a systematic way, so that we do not have to that manually anymore.

We use `ssort` to sort the definitions in the source
files in a systematic way, so that we do not have to that manually
anymore.
@mristin
Copy link
Contributor Author

mristin commented Jan 26, 2024

@empwilli this is a huge re-formatting change, but there are no changes in the logic. It's been pending for quite some time, and I finally found time to fix the order of definitions.

Please make sure that you re-base your branch as soon as possible, and also run against ssort with the changed precommit.py from this patch.

@mristin mristin merged commit d914e86 into main Jan 26, 2024
3 checks passed
@mristin mristin deleted the mristin/Introduce-isort-and-ssort branch January 26, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant