Namespaces / Packages in generated *.proto #539
Conversation
| @@ -484,6 +484,10 @@ def generate( | |||
|
|
|||
| package {namespace}; | |||
|
|
|||
| option csharp_namespace = "AasCore.Aas3_0.Proto"; | |||
There was a problem hiding this comment.
You need to insert the appropriately named package here. You need to import all the {lang. name}/naming.py.
There was a problem hiding this comment.
let's discuss it tomorrow
|
(Sorry for terse comment, reviewing and typing on my phone.) |
|
After a call with @TomGneuss, we decided to close the issue, since we do not want to prime the users on the fixed namespace, as we do not plan to maintain the generated code. Hence, we decide to leave it open to the end-user (of the Protobuf definitions) to specify their own namespace. A related issue in protoc: protocolbuffers/protobuf#6846 We suggest to semantically patch the *.proto file(s) in the future and add the namespace only once we start working on aas-core3.0-csharp-protobuf or aas-core3.0-java-protobuf. |
Previously, the *.proto files did not contain any hints about the namespace/package names in the target language. Thus, the protoc compiler just generated default namespaces.
Using the options as specified in this PR, the namespaces in the target languages of protoc are known beforehand.