Merge pull request #50 from abbastoof/feature/019-user-profile-management

turned the serializer.validationerror to a list of errors in views.py…

Author: mtoof

Backend/user_service/user_service/user_app/serializers.py

@@ -68,7 +68,7 @@ def create(self, validate_data) -> User:
         try:
             validate_password(validate_data["password"])
         except ValidationError as err:
-            raise serializers.ValidationError({"password": err.messages}) from err
+            raise serializers.ValidationError(detail=err.messages) from err
         password = validate_data.pop("password", None)
         instance = self.Meta.model(**validate_data)
         if password is not None:
@@ -97,20 +97,14 @@ def update(self, instance, validate_data) -> User:
         for attr, value in validate_data.items():
             if attr == "password" and value is not None:
                 if instance.check_password(value):
-                    raise serializers.ValidationError(
-                        {
-                            "password": "New password must be different from the current password."
-                        }
-                    )
+                    raise serializers.ValidationError(detail="New password must be different from the current password.")
 
                 # Validate the new password using CustomPasswordValidator
                 try:
                     validator = CustomPasswordValidator()
                     validator.validate(value, user=instance)
                 except ValidationError as err:
-                    raise serializers.ValidationError(
-                        {"password": err.messages}
-                    ) from err
+                    raise serializers.ValidationError(detail=err.messages) from err
                 instance.set_password(value)
             else:
                 setattr(instance, attr, value)

Backend/user_service/user_service/user_app/validators.py

@@ -14,38 +14,35 @@ def validate(self, password, user=None):
         errors = []
 
         if len(password) < self.minlength:
-            errors.append(
+            raise ValidationError(
                 _("This password must contain at least {minlength} characters.").format(minlength=self.minlength)
             )
 
         if sum(1 for c in password if c.islower()) < self.minlower:
-            errors.append(
+            raise ValidationError(
                 _("This password must contain at least {minlower} lowercase letter(s).").format(minlower=self.minlower)
             )
 
         if sum(1 for c in password if c.isupper()) < self.minupper:
-            errors.append(
+            raise ValidationError(
                 _("This password must contain at least {minupper} uppercase letter(s).").format(minupper=self.minupper)
             )
 
         if sum(1 for c in password if c.isdigit()) < self.mindigit:
-            errors.append(
+            raise ValidationError(
                 _("This password must contain at least {mindigit} digit(s).").format(mindigit=self.mindigit)
             )
 
         if sum(1 for c in password if c in self.special_characters) < self.minspecial:
-            errors.append(
+            raise ValidationError(
                 _("This password must contain at least {minspecial} special character(s) from {specials}.").format(minspecial=self.minspecial, specials=self.special_characters)
             )
 
         if user and user.check_password(password):
-            errors.append(
+            raise ValidationError(
                 _("The new password cannot be the same as the old password.")
             )
 
-        if errors:
-            raise ValidationError(errors)
-
     def get_help_text(self):
         """
             Get the help text for the password validator.

Backend/user_service/user_service/user_app/views.py

@@ -131,6 +131,11 @@ def update_user(self, request, pk=None) -> Response:
             serializer.save()
             # if User updated Username should send message to all microservices to update the username related to this user using Kafka
             return Response(serializer.data, status=status.HTTP_202_ACCEPTED)
+        except ValidationError as err:
+            item_lists = []
+            for item in err.detail:
+                item_lists.append(item)
+            return Response({'error': item_lists}, status=status.HTTP_400_BAD_REQUEST)
         except Exception as err:
             return Response({"error": str(err)}, status=status.HTTP_400_BAD_REQUEST)
 
@@ -194,7 +199,10 @@ def create_user(self, request) -> Response:
                     data["email"] = ["A user with that email already exists."]
             return Response({"error":data}, status=status.HTTP_400_BAD_REQUEST)
         except ValidationError as err:
-            return Response({'error': err}, status=status.HTTP_400_BAD_REQUEST)
+            item_lists = []
+            for item in err.detail:
+                item_lists.append(item)
+            return Response({'error': item_lists}, status=status.HTTP_400_BAD_REQUEST)
 
 class FriendsViewSet(viewsets.ViewSet):
     authentication_classes = [JWTAuthentication]