Chore/030 setup game server socketio #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… update statuses. next: add socket code to frontend service
… is updated on regular intervals and paddle movement does not speed up the game
…into chore/030-setup-game-server-socketio
… random player and game id's, next plan is to handle those and protect frontend from receiving wrong data and also server to validate the data
…me is launched, these numbers are used to create game session in server. was able to successfully run multiple game sessions simultaneously
…y from other machines in same network, fixed scss issue
…on and 3001 for dev mode
…th game-server/socket.io instead of default path to make sure it overlap with other possible socket connections, updated readme
|
Solved conflicts, merging. |
|
Beep boop assimilation commencing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #30
Server runs as a plain python app, no django leftovers are present.
Socket.io connection is estabilished, path in the server is default /socket.io, but in order to differentiate this from other possible socket.io connections, the proxy config routes the the path as /game-server/socket.io, which will be then redirected to the game-server service in path /socket.io
Currently a new remote game is launched when "local game" is clicked on front page. Currently have not tested if this connection works when logged in, also it seems that a game session is not deleted from server when players leave, need to be fixed.
Frontend also contains fixes to styles to work with SCSS.