Feature/055 local tournament integration #64
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ill be called in the end of the game. updated docs
…'s, localstorage value to track whether it's safe to start next game, blocked game from sending wrong results to tournament
…ne how to continue in tournament logic. muted unnecessary console.logs and temporarily match stops at 1 goal
9 tasks
trsctr
requested changes
Aug 13, 2024
There was a problem hiding this comment.
please hide the play and randomize buttons from the modal until user has selected the player amount, play seems to crash the whole thing. cancel button could be useful too. otherwise looks good to me, great job!
also at gamestate.py, line 182, please change the score limit back to 10
…rom tournament.js and replaced with necessary single clearings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local tournament logic rewritten. Added info screen after matches.