Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rottentomatos #1

Open
abeadam opened this issue Jan 14, 2014 · 1 comment
Open

rottentomatos #1

abeadam opened this issue Jan 14, 2014 · 1 comment

Comments

@abeadam
Copy link
Owner

abeadam commented Jan 14, 2014

/cc @nesquena @timothy1ee
spent my weekend going about doing it the wrong way, found video on monday for way we are suppose to actually do it, apologize was short on my rottentomatos2

@timothy1ee
Copy link

Nice start, I'll accept this submission, but you should keep working on it. The point of this homework was to explore a simple example of a full MVC application with a RESTful API. When I'm auditing the code, I use the checklist below. If you didn't do one of the items below, you should consider implementing it.

  • Movie model. Did you have some way to create it from a dictionary?
  • You should have implemented a custom cell. When creating a custom cell, make sure never to use imageView, titleLabel, or subtitleLabel. Those are already used by UITableViewCell and using them in your custom cell will cause subtle things to happen such as image views not loading until you click on the cell.
  • If you chose to embed an image, you should have loaded the images asynchronously. One way to do that was to use AFNetworking, installed via CocoaPods.
  • If you had an image, you should observe the UIContentMode of the UIImageView. By default, it will stretch the image to match your dimensions, which is probably not what you want.
  • If you had a custom cell, you should configure the Auto Layout parameters. We'll review that in class.
  • Optionally, you could have displayed some loading indicator while you were fetching the movies.
  • Optionally, you could have displayed an error if you failed while fetching the movies. Preferably something better than the default UIAlertView. Check out what Twitter or Instagram does if there is a network error.
  • Optionally, you could have created a MovieViewController which is launched if a user taps on a row. This will expose you to segues, especially since you'll want to set the movie on the MovieViewController to the one you tapped on. See this gist for a code snippet of how to set the movie: https://gist.github.com/timothy1ee/8393719.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants