Skip to content

add disable_ping_events flag #1257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2024
Merged

add disable_ping_events flag #1257

merged 1 commit into from
Apr 17, 2024

Conversation

khimaros
Copy link
Contributor

@khimaros khimaros commented Mar 5, 2024

for backward compatibility, this is false by default. it can be set to true to disable EventSource pings which are not supported by some OpenAI clients. fixes #1256

@khimaros khimaros changed the title add enable_ping_events flag add disable_ping_events flag Mar 5, 2024
@khimaros
Copy link
Contributor Author

synced with main branch

for backward compatibility, this is false by default

it can be set to true to disable EventSource pings
which are not supported by some OpenAI clients.

fixes #1256
@abetlen abetlen merged commit b73c73c into abetlen:main Apr 17, 2024
16 checks passed
@abetlen
Copy link
Owner

abetlen commented Apr 17, 2024

Hey @khimaros thank you for the contribution!

@khimaros khimaros deleted the ping-events-flag branch April 23, 2024 19:51
xhedit pushed a commit to xhedit/llama-cpp-conv that referenced this pull request Apr 30, 2024
for backward compatibility, this is false by default

it can be set to true to disable EventSource pings
which are not supported by some OpenAI clients.

fixes abetlen#1256
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add flag to disable EventSourceReponse ping messages
2 participants