Enable detokenizing special tokens #1596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benniekiss
force-pushed
the
detokenize_special
branch
3 times, most recently
from
ac6efb6 to
0e6d843
Compare
benniekiss
force-pushed
the
detokenize_special
branch
from
0e6d843 to
b884fc6
Compare
|
Hey @abetlen , when you get a chance, would you give this a review? |
benniekiss
force-pushed
the
detokenize_special
branch
3 times, most recently
from
0f105ba to
bf241c1
Compare
benniekiss
force-pushed
the
detokenize_special
branch
2 times, most recently
from
c75f724 to
e3e7da0
Compare
benniekiss
force-pushed
the
detokenize_special
branch
3 times, most recently
from
39d4f0e to
c4f73a2
Compare
benniekiss
force-pushed
the
detokenize_special
branch
from
c4f73a2 to
e1cc07d
Compare
|
Hey @benniekiss thank you for the contribution! I reverted the changes to |
|
That's perfect! Thank you for taking the time to review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that it was not possible to detokenize special tokens, such as the EOS token, when using Phi-3(.1). This PR makes sure that the
specialflag can be passed to thedetokenize()method of both theLlamaTokenizerand theLlamaHFTokenizerI also noticed that
prev_tokenswas not being used in the detokenize method ofLlamaTokenizer, so this PR also adds that functionality based onLlamaHFTokenizer