Skip to content

checkA11y - skipFailure options not working when reporter is 'junit' #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

iamhoonse
Copy link

Problem

I have the following usage of checkA11y function,
skipFailures is set to be true, and reporter is "junit".

    // Check a11y for current story and report results in JUnit format
    await checkA11y(page, element, {}, true, "junit", {
      outputDirPath: "test-results",
      outputDir: "a11y-audit",
      reportFileName: `${storyContext.title}.xml`,
    });

However, this setting gave me result like below,
as if skipFailures option has no effect when reporter is set to "junit".

image

Changes

To fix this problem, I propose some changes in function checkA11y().

Result

By applying changes, now skipFailures option has effect like below.

false true
image image

…e` options not working when reporter is 'junit'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant