-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added API parameter 'workforce' #259
Conversation
Allows to set the parameter 'workforce' via the Wordpress REST-API. The value type must be integer. Changes to be committed: modified: src/Api/Reports.php modified: src/DataAccess/ReportInserter.php modified: src/Model/ReportInsertObject.php
Changes in Reports.php: 'content' sanitize callback chaged to "wp_kses_post". This allows, e.g., to include images that have been uploaded separately via FTP
Settings had to be thrown away to get PhpStorm working on a new machine, so let's not track those files
config:recommended is only available from v36 onwards
Configure Renovate
chore(deps): pin dependencies
…on-major) chore(deps): update devdependencies (non-major)
…s-wpcs-3.x chore(deps): update dependency wp-coding-standards/wpcs to v3
…on-major) chore(deps): update dependency phpunit/phpunit to v9.6.12
…on-major) chore(deps): update dependency wp-coding-standards/wpcs to v3.0.1
…on-major) chore(deps): update dependency phpunit/phpunit to v9.6.13
Test with PHP 8.2
…on-major) chore(deps): update dependency phpmd/phpmd to v2.14.1
…on-major) chore(deps): update dependency phpunit/phpunit to v9.6.15
chore(deps): pin docker digests
…on-major) chore(deps): update devdependencies (non-major)
…desniffer-composer-installer-1.x chore(deps): update dependency dealerdirect/phpcodesniffer-composer-installer to v1
…on-major) chore(deps): update devdependencies (non-major)
…on-major) chore(deps): update devdependencies (non-major) to v1.5.0
chore(deps): update php docker tag to v8.3.2
shortcode [einsatzliste options=special] will show report with images instead of reports marked "special"
Thanks for this suggestion. The value being an integer makes sense, this is also how the value was stored internally in the early days of the plugin. Since then, the data type changed to a regular string due to user feedback (people wanted to enter values like "1/8"). In the meantime I somewhat regretted it to give up the restriction to integer and I am considering making the workforce field in its current form optional. This would happen as part of #169, which would introduce custom fields for reports. Each custom field would have a data type for validation. As a consequence of that, the addition of a way to fill those custom fields over the API would make sense. But until then, I would not want to add a parameter |
Allows to set the parameter 'workforce' via the Wordpress REST-API. The value type must be integer.
Changes to be committed:
modified: src/Api/Reports.php
modified: src/DataAccess/ReportInserter.php
modified: src/Model/ReportInsertObject.php