Fixes

Author: lalinsky

src/Index.zig

@@ -227,7 +227,7 @@ fn loadSegment(self: *Self, segment_id: SegmentID) !void {
 fn loadSegments(self: *Self) !void {
     const segment_ids = filefmt.readIndexFile(self.data_dir, self.allocator) catch |err| {
         if (err == error.FileNotFound and self.options.create) {
-            try filefmt.writeIndexFile(self.data_dir, std.ArrayList(SegmentID).init(self.allocator));
+            try filefmt.writeIndexFile(self.data_dir, &[_]SegmentID{});
             return;
         }
         return err;
@@ -262,7 +262,7 @@ fn doCheckpoint(self: *Self) !bool {
 
     try ids.append(dest.data.id);
 
-    try filefmt.writeIndexFile(self.data_dir, ids);
+    try filefmt.writeIndexFile(self.data_dir, ids.items);
 
     self.segments_lock.lock();
     defer self.segments_lock.unlock();
@@ -448,7 +448,7 @@ fn finishFileSegmentMerge(self: *Self, merge: FileSegmentList.PreparedMerge) !vo
 
     std.debug.assert(std.sort.isSorted(SegmentID, ids.items, {}, SegmentID.cmp));
 
-    try filefmt.writeIndexFile(self.data_dir, ids);
+    try filefmt.writeIndexFile(self.data_dir, ids.items);
 
     defer self.file_segments.destroySegment(merge.sources.node1);
     defer self.file_segments.destroySegment(merge.sources.node2);

src/filefmt.zig

@@ -502,7 +502,7 @@ const IndexFileHeader = struct {
     }
 };
 
-pub fn writeIndexFile(dir: std.fs.Dir, segments: std.ArrayList(SegmentVersion)) !void {
+pub fn writeIndexFile(dir: std.fs.Dir, segments: []const SegmentVersion) !void {
     log.info("writing index file {s}", .{index_file_name});
 
     var file = try dir.atomicFile(index_file_name, .{});
@@ -512,7 +512,7 @@ pub fn writeIndexFile(dir: std.fs.Dir, segments: std.ArrayList(SegmentVersion))
     const writer = buffered_writer.writer();
 
     try msgpack.encode(writer, IndexFileHeader, .{});
-    try msgpack.encode(writer, []SegmentVersion, segments.items);
+    try msgpack.encode(writer, []const SegmentVersion, segments);
 
     try buffered_writer.flush();
 
@@ -522,7 +522,7 @@ pub fn writeIndexFile(dir: std.fs.Dir, segments: std.ArrayList(SegmentVersion))
 
     log.info("wrote index file {s} (segments = {})", .{
         index_file_name,
-        segments.items.len,
+        segments.len,
     });
 }
 
@@ -547,17 +547,16 @@ test "readIndexFile/writeIndexFile" {
     var tmp = testing.tmpDir(.{});
     defer tmp.cleanup();
 
-    var segments = std.ArrayList(SegmentVersion).init(testing.allocator);
-    defer segments.deinit();
-
-    try segments.append(.{ .version = 1, .included_merges = 0 });
-    try segments.append(.{ .version = 2, .included_merges = 1 });
-    try segments.append(.{ .version = 4, .included_merges = 0 });
+    const segments = [_]SegmentVersion{
+        .{ .version = 1, .included_merges = 0 },
+        .{ .version = 2, .included_merges = 1 },
+        .{ .version = 4, .included_merges = 0 },
+    };
 
-    try writeIndexFile(tmp.dir, segments);
+    try writeIndexFile(tmp.dir, &segments);
 
     const segments2 = try readIndexFile(tmp.dir, std.testing.allocator);
     defer std.testing.allocator.free(segments2);
 
-    try testing.expectEqualSlices(SegmentVersion, segments.items, segments2);
+    try testing.expectEqualSlices(SegmentVersion, &segments, segments2);
 }