Fix inherited cti.reference check

acronis · Feb 25, 2025 · 33fa16d · 33fa16d
1 parent 59c2397
commit 33fa16d
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/metadata/validator/validator.go b/metadata/validator/validator.go
@@ -173,17 +173,15 @@ func (v *MetadataValidator) Validate(current *metadata.Entity) error {
 			if parentRef != TrueStr && currentRef == TrueStr {
 				return fmt.Errorf("%s@%s: parent cti.reference defines a specific CTI, but child specifies true", current.Cti, key)
 			}
-			if currentRef == TrueStr {
+			// If either the parent or the current reference is true, then we don't need to validate the reference
+			if currentRef == TrueStr || parentRef == TrueStr {
 				continue
 			}
-			expr, err := v.ctiParser.Parse(currentRef)
+			expr, err := v.ctiParser.Parse(parentRef)
 			if err != nil {
 				return fmt.Errorf("%s@%s: %s", current.Cti, key, err.Error())
 			}
-			if parentRef == TrueStr {
-				continue
-			}
-			if err := v.matchCti(&expr, parentRef); err != nil {
+			if err := v.matchCti(&expr, currentRef); err != nil {
 				return fmt.Errorf("%s@%s: %s", current.Cti, key, err.Error())
 			}
 		}