Skip to content

fix: Remove cursor:pointer from header-style mixin #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2019

Conversation

patrickhlauke
Copy link
Contributor

While it's true that most elements that use this mixin are also interactive, it is also used on static elements ... and here, having the explicit cursor:pointer mouse cursor (the "hand" one) is misleading and confusing, as it makes those static elements appear to be interactive/clickable to sighted mouse users.

Closes #54
Closes #69

While it's true that most elements that use this mixin are also interactive, it is also used on static elements ... and here, having the explicit `cursor:pointer` mouse cursor (the "hand" one) is misleading and confusing, as it makes those static elements appear to be interactive/clickable to sighted mouse users.

Closes act-rules#54
Closes act-rules#69
@jeeyyy jeeyyy changed the title Remove cursor:pointer from header-style mixin fix: Remove cursor:pointer from header-style mixin Nov 21, 2019
@jeeyyy jeeyyy merged commit 2a058f7 into act-rules:master Nov 21, 2019
@jeeyyy
Copy link
Collaborator

jeeyyy commented Nov 21, 2019

Thanks @patrickhlauke

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cursor:pointer on static paragraphs in navigation sidebar <h1> headings are non-interactive but have cursor:pointer
2 participants