-
Notifications
You must be signed in to change notification settings - Fork 75
Consider accessible description in the rules that use link context (5effbb, fd3a94) #1845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel it would be cleaner to remove aria-describedby
from "Programmatically determined link context". Since the rules now explicitly mention the accessible description, that already includes aria-describedby
references (and actually a few more things such as children of aria-describedby
references, if I get the accessible name computation correctly).
So, the PDLC would be some set of elements defined by some DOM tree relationship, and rules about context would look at PDLC + accessible description.
(it would also means that aria-describedby="foo bar"
and aria-describedby="bar foo"
would be considered as different accessible descriptions while they are currently the same PDLC, which sounds bad)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggestions made.
@@ -77,7 +78,7 @@ This rule is designed specifically for [2.4.4 Link Purpose (In Context)][sc244], | |||
|
|||
#### Passed Example 1 | |||
|
|||
These two HTML `a` elements have the same [accessible name][] and [context][programmatically determined link context] and link to the [same resource][]. | |||
These two HTML `a` elements have the same [accessible name][], [accessible description][] and [context][programmatically determined link context] and link to the [same resource][]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be helpful to say "same non-empty accessible name, empty accessible description..."?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added it in a couple other spots.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like Kathy's suggestions on these, would like to see them made.
Good suggestion. I'm updating the definition accordingly. |
Co-authored-by: Kathy Eng <kengdoj@users.noreply.github.com>
_rules/links-with-identical-names-and-context-serve-equivalent-purpose-fd3a94.md
Outdated
Show resolved
Hide resolved
_rules/links-with-identical-names-and-context-serve-equivalent-purpose-fd3a94.md
Outdated
Show resolved
Hide resolved
…-purpose-fd3a94.md Co-authored-by: Kathy Eng <kengdoj@users.noreply.github.com>
…-purpose-fd3a94.md Co-authored-by: Kathy Eng <kengdoj@users.noreply.github.com>
@@ -337,6 +347,7 @@ This `a` element is not a [semantic][semantic role] `link`, because it has no `h | |||
``` | |||
|
|||
[accessible name]: #accessible-name 'Definition of Accessible Name' | |||
[accessible description]: https://www.w3.org/TR/wai-aria-1.2/#dfn-accessible-description 'Definition of accessible description' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we have our own def of it (like for accessible name?), I'm notably thinking we should link it to the "accessible name and description computation" document.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a definition of accessible description
_rules/links-with-identical-names-and-context-serve-equivalent-purpose-fd3a94.md
Outdated
Show resolved
Hide resolved
I figured there must be an easier way. Thank you, I've noted it for next time. |
_rules/links-with-identical-names-and-context-serve-equivalent-purpose-fd3a94.md
Outdated
Show resolved
Hide resolved
_rules/links-with-identical-names-and-context-serve-equivalent-purpose-fd3a94.md
Outdated
Show resolved
Hide resolved
_rules/links-with-identical-names-and-context-serve-equivalent-purpose-fd3a94.md
Outdated
Show resolved
Hide resolved
_rules/links-with-identical-names-and-context-serve-equivalent-purpose-fd3a94.md
Outdated
Show resolved
Hide resolved
_rules/links-with-identical-names-and-context-serve-equivalent-purpose-fd3a94.md
Outdated
Show resolved
Hide resolved
_rules/links-with-identical-names-and-context-serve-equivalent-purpose-fd3a94.md
Outdated
Show resolved
Hide resolved
_rules/links-with-identical-names-and-context-serve-equivalent-purpose-fd3a94.md
Outdated
Show resolved
Hide resolved
_rules/links-with-identical-names-and-context-serve-equivalent-purpose-fd3a94.md
Outdated
Show resolved
Hide resolved
_rules/links-with-identical-names-and-context-serve-equivalent-purpose-fd3a94.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Editorial changes for consistency
Co-authored-by: Kathy Eng <kengdoj@users.noreply.github.com>
@@ -35,7 +35,7 @@ This rule applies to any [inheriting semantic][] `link` for which all the follow | |||
|
|||
## Expectation | |||
|
|||
The [accessible name][] of each target element together with its [programmatically determined link context][] describes the purpose of the link. | |||
The [accessible name][] of each target element together with its [accessible description][] and [programmatically determined link context][] describes the purpose of the link. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this is obviously correct. The SC talks about link text and programmatically determined context. Its probably worth putting in the assumption that we're using "link text" from WCAG to mean accessible name and description. Links that fail label in name could have visible text that isn't considered "link text" in this rule. I think that should be in the assumption.
Carlos Duarte seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Update rules that use link context to consider the title attribute. Although the original resolution in #1766 requested the changes to be made on the "Programmatically Determined Link Context" definition, given that this specifies a set of elements, it does not seem doable. As an alternative, I've added the accessible description to the expectation of "Link in context is descriptive" and to the applicability of "Links with identical accessible names and context serve equivalent purpose"
Closes issue(s):
b20e66
,5effbb
,aizyf1
,fd3a94
) consider thetitle
attribute? #1766Need for Call for Review:
This will require a 2 weeks Call for Review
How to Review And Approve