-
Notifications
You must be signed in to change notification settings - Fork 75
Consider accessible description in the rules that use link context (5effbb, fd3a94) #1845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
carlosapaduarte
wants to merge
26
commits into
develop
Choose a base branch
from
include-title-attribute-in-link-context
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
1746bf8
Update links-with-identical-names-and-context-serve-equivalent-purpos…
carlosapaduarte 2d271ab
Update link-in-context-descriptive-5effbb.md
carlosapaduarte 0b07c9d
Merge branch 'develop' into include-title-attribute-in-link-context
carlosapaduarte 3bf682f
Merge branch 'develop' into include-title-attribute-in-link-context
carlosapaduarte 1f6fcd2
Merge branch 'develop' into include-title-attribute-in-link-context
carlosapaduarte 1918c30
Update _rules/link-in-context-descriptive-5effbb.md
carlosapaduarte bc72adf
Remove aria-describedby from the programmatically determined link con…
carlosapaduarte 0a576aa
update example description
carlosapaduarte 637c43c
fix order of headings
carlosapaduarte 8df5b30
Update _rules/links-with-identical-names-and-context-serve-equivalent…
carlosapaduarte b52c6f3
Update _rules/links-with-identical-names-and-context-serve-equivalent…
carlosapaduarte 8b23479
Update _rules/links-with-identical-names-and-context-serve-equivalent…
16dfe6b
add definition of accessible description
carlosapaduarte 7986cd1
use definition of accessible description
carlosapaduarte 6b141c4
use definition of accessible description
carlosapaduarte a7f9cec
add example with aria-describedby
carlosapaduarte 29c31b0
Changes from review
carlosapaduarte 1bd8c51
Merge branch 'develop' into include-title-attribute-in-link-context
91fb0bc
Merge branch 'develop' into include-title-attribute-in-link-context
4870c48
Apply suggestions from code review
b32d0b6
Merge branch 'develop' into include-title-attribute-in-link-context
d1d7cfe
Merge branch 'develop' into include-title-attribute-in-link-context
3ff697a
Merge branch 'develop' into include-title-attribute-in-link-context
47f5b1a
Update link-in-context-descriptive-5effbb.md
b664ffb
Merge branch 'develop' into include-title-attribute-in-link-context
carlosapaduarte 6260db4
Fix repeated inapplicable example number
carlosapaduarte File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
--- | ||
title: Accessible Description | ||
key: accessible-description | ||
unambiguous: true | ||
objective: true | ||
input_aspects: | ||
- Accessibility tree | ||
- CSS styling | ||
- DOM tree | ||
--- | ||
|
||
The _accessible description_ is the programmatically determined description of a user interface element that is [included in the accessibility tree](#included-in-the-accessibility-tree). The accessible description provides information that complements the [accessible name][]. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Never noticed that our def of "accessible name" is only for "UI element" 🤔 Feels a bit weird or restrictive (and maybe ambiguous since we usually use "instrument"). Again not related to this PR. |
||
|
||
The accessible description is calculated using the [accessible name and description computation][]. | ||
|
||
For native markup languages, such as HTML and SVG, additional information on how to calculate the accessible description can be found in [HTML Accessibility API Mappings 1.0, Accessible Name and Description Computation (working draft)](https://www.w3.org/TR/html-aam/#accessible-name-and-description-computation) and [SVG Accessibility API Mappings, Name and Description (working draft)](https://www.w3.org/TR/svg-aam/#mapping_additional). | ||
|
||
**Note:** As per the [accessible name and description computation][], each element with the 'aria-describedby' property always has an accessible description. | ||
|
||
[accessible name]: #accessible-name 'Definition of Accessible Name' | ||
[accessible name and description computation]: https://www.w3.org/TR/accname 'Accessible Name and Description Computation' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this is obviously correct. The SC talks about link text and programmatically determined context. Its probably worth putting in the assumption that we're using "link text" from WCAG to mean accessible name and description. Links that fail label in name could have visible text that isn't considered "link text" in this rule. I think that should be in the assumption.