Skip to content

Update autocomplete-valid-value-73f2c2.md #1907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

giacomo-petri
Copy link
Collaborator

Updates:

  • updated fixed values list item in Applicability section adding necessary type values to reflect html specs;
  • removed "hidden" type from that list;
  • added background note both to better explain fixed values and to clarify autofill anchor mantle for input type hidden.

Closes issue(s):

Need for Call for Review:
This will require a 2 weeks Call for Review


Pull Request Etiquette

When creating PR:

  • Make sure you're requesting to pull a branch (right side) to the develop branch (left side).
  • Make sure you do not remove the "How to Review and Approve" section in your pull request description

After creating PR:

  • Add yourself (and co-authors) as "Assignees" for PR.
  • Add label to indicate if it's a Rule, Definition or Chore.
  • Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
  • Optionally request feedback from anyone in particular by assigning them as "Reviewers".

When merging a PR:

  • Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

@Jym77 Jym77 added Rule Update Use this label for an existing rule that is being updated reviewers wanted labels Aug 5, 2022
Copy link
Member

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably worth adding some inapplicable examples for this.

@giacomo-petri
Copy link
Collaborator Author

giacomo-petri commented Aug 11, 2022

It's probably worth adding some inapplicable examples for this.

Good catch. Added input type submit and hidden examples (trying to explain with an example the idea of the autofill anchor mantle).

Co-authored-by: HelenBurge <41951878+HelenBurge@users.noreply.github.com>
Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>
@giacomo-petri giacomo-petri requested a review from Jym77 September 26, 2022 10:23
@Jym77 Jym77 dismissed stale reviews from HelenBurge and WilcoFiers September 29, 2022 08:03

Some changes done

Jym77
Jym77 previously requested changes Sep 29, 2022
@HelenBurge HelenBurge dismissed Jym77’s stale review November 24, 2022 14:25

As changes were made so worth rechecking

@giacomo-petri giacomo-petri added the Review call 2 weeks Call for review for new rules and big changes label Jan 30, 2023
@giacomo-petri
Copy link
Collaborator Author

Call for review ends on February 13th.

@carlosapaduarte
Copy link
Member

Call for review ended. Merging...

@carlosapaduarte carlosapaduarte merged commit 2531671 into act-rules:develop Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review call 2 weeks Call for review for new rules and big changes reviewers wanted Rule Update Use this label for an existing rule that is being updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autocomplete attribute has valid value - Input type image [73f2c2]
6 participants