button name move assumption to the correct section #2286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jym77
approved these changes
Feb 7, 2025
giacomo-petri
approved these changes
Apr 10, 2025
zlayaAvocado
approved these changes
May 1, 2025
zlayaAvocado
requested changes
May 1, 2025
| @@ -39,12 +39,12 @@ This rule considers an exception for "image buttons" (i.e., `input` elements wit | |||
|
|
|||
| - The rule assumes that all buttons are [user interface components as defined by WCAG 2](https://www.w3.org/TR/WCAG22/#dfn-user-interface-components). | |||
|
|
|||
| - Some elements have a role of `button` and a default accessible name defined by the [HTML Accessibility API Mapping][html aam input button], for example `input` elements whose `type` [attribute value][] is either `submit` or `reset`. This rule considers that these default names can be descriptive and therefore does not fail them. | |||
There was a problem hiding this comment.
Should the HTML Accessibility API Mapping link be updated? It seems it's currently not referencing anything and goes to the whole file instead, new link: https://www.w3.org/TR/html-aam-1.0/#input-type-button-input-type-submit-and-input-type-reset-accessible-name-computation
The same issue is in the "Bibliography" section of the rule
❌ Deploy Preview for act-rules failed.
|
zlayaAvocado
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an assumption, not an accessibility support issue.
Need for Call for Review: none
How to Review And Approve