-
Notifications
You must be signed in to change notification settings - Fork 75
New manual rule: Correct captions #2301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
||
A video element with an explicitly associated text on the same page that describes the audio in the video. | ||
A video element with an explicitly associated text on the same page that describes the audio in the video but no captions. | ||
|
||
```html | ||
<p id="text"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On line 137 there is a problem that this PR didn't create, but I noticed it while reviewing: it says ariadescribedby="text". That's missing a hyphen. It should be: aria-describedby="text"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
corrected. Thanks!
✅ Deploy Preview for act-rules ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Co-authored-by: Dan Tripp <113939352+dan-tripp-siteimprove@users.noreply.github.com>
wcag20:1.2.4: # Captions (Live) (AA) | ||
forConformance: true | ||
failed: not satisfied | ||
passed: further testing needed | ||
inapplicable: further testing needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The applicability ignores non-streaming videos. I think that's the right call here, the same video cannot fail both criteria, so you'll need to remove 1.2.4 from this.
wcag20:1.2.4: # Captions (Live) (AA) | |
forConformance: true | |
failed: not satisfied | |
passed: further testing needed | |
inapplicable: further testing needed |
|
||
## Background | ||
|
||
### Assumptions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're making the assumption that a video with captions doesn't isn't also a media alternative. I think a video could in theory have incorrect captions, but still pass 1.2.2 if it's a media alternative. That's pretty theoretical though so I think an assumption about that is fine.
New manual rule for correct captions:
Need for Call for Review:
This will require a 2 weeks Call for Review
Pull Request Etiquette
When creating PR:
develop
branch (left side).After creating PR:
Rule
,Definition
orChore
.When merging a PR:
How to Review And Approve