Skip to content

Update permitted ARIA state or property for combobox role #2322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

shunguoy
Copy link
Collaborator

@shunguoy shunguoy commented Apr 16, 2025

<< Describe the changes >>
Per the latest ARIA spec, change the permitted ARIA state or property for "combobox" role from "aria-controls" to "aria-expanded" in the Pass example 6, 7 & 8.

Closes issue(s):

Need for Call for Review:

This will require a 1 week Call for Review

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

Copy link

netlify bot commented Apr 16, 2025

Deploy Preview for act-rules ready!

Name Link
🔨 Latest commit da1650e
🔍 Latest deploy log https://app.netlify.com/sites/act-rules/deploys/681cc30db268a60008f7957c
😎 Deploy Preview https://deploy-preview-2322--act-rules.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shunguoy shunguoy self-assigned this Apr 16, 2025
@shunguoy shunguoy added the Review Call 1 week Call for review for small changes label Apr 17, 2025
@WilcoFiers WilcoFiers removed the Review Call 1 week Call for review for small changes label May 1, 2025
Copy link
Member

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpick. I also think we should add something to the background noting the change in ARIA 1.3.

@shunguoy
Copy link
Collaborator Author

shunguoy commented May 7, 2025

@WilcoFiers Added a reference to ARIA 1.3 in the background section, and other changes you mentioned. ALso fixed some merge conflicts.

@WilcoFiers WilcoFiers dismissed their stale review May 8, 2025 14:39

sorted

Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[5c01ea] ARIA state or property is permitted - Passed Example 6-7-8-10-12 improvement
3 participants