-
Notifications
You must be signed in to change notification settings - Fork 75
Update permitted ARIA state or property for combobox role #2322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for act-rules ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nitpick. I also think we should add something to the background noting the change in ARIA 1.3.
Update the property value Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
@WilcoFiers Added a reference to ARIA 1.3 in the background section, and other changes you mentioned. ALso fixed some merge conflicts. |
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
<< Describe the changes >>
Per the latest ARIA spec, change the permitted ARIA state or property for "combobox" role from "aria-controls" to "aria-expanded" in the Pass example 6, 7 & 8.
Closes issue(s):
Need for Call for Review:
This will require a 1 week Call for Review
How to Review And Approve