Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Live Server fixtures back to package scope #20

Closed
markhobson opened this issue Oct 9, 2023 · 1 comment
Closed

Move Live Server fixtures back to package scope #20

markhobson opened this issue Oct 9, 2023 · 1 comment
Labels
technical Technical issue
Milestone
0.3.0

Comments

@markhobson
Copy link
Contributor

To workaround Playwright hanging on teardown we've changed the scope of Live Server fixtures to class. We should move these back to session when this bug is fixed so that single instances of the app/OIDC server run during the e2e test run.
@markhobson markhobson added the technical Technical issue label Oct 9, 2023
@markhobson markhobson mentioned this issue Oct 9, 2023
Open
markhobson added a commit that referenced this issue Oct 13, 2023
@markhobson
GH-20: Widen LiveServer fixture scopes to session
62d03b5
@markhobson markhobson added this to the 0.3.0 milestone Oct 13, 2023
@markhobson
Copy link
Contributor Author

Introducing web APIs for our live servers allowed us to move their fixtures scope back to session. Decided to narrow this slightly to package to avoid e2e test fixtures bleeding into integration tests.

@markhobson markhobson changed the title Move Live Server fixtures back to session scope Move Live Server fixtures back to package scope Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
technical Technical issue
Projects
None yet
Milestone
0.3.0
Development

No branches or pull requests
1 participant
@markhobson