Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pytest-base-url plugin for page object URLs #21

Open
markhobson opened this issue Oct 9, 2023 · 3 comments
Open

Use pytest-base-url plugin for page object URLs #21

markhobson opened this issue Oct 9, 2023 · 3 comments
Assignees
@markhobson
Labels
technical Technical issue

Comments

@markhobson
Copy link
Contributor

markhobson commented Oct 9, 2023 •
edited
Loading

We currently derive the app's base URL from the Flask app in e2e tests. This would be simplified if we used pytest-base-url to automatically configure Playwright with the app's base URL.
@markhobson markhobson added the technical Technical issue label Oct 9, 2023
@markhobson
Copy link
Contributor Author

Currently blocked in doing this by #20 as pytest-base-url's _verify_url fixture is fixed to session scope.

@markhobson
Copy link
Contributor Author

Decided upon package scope for e2e live servers, but this is still problematic for pytest-base-url which is hardcoded to session.

@markhobson
Copy link
Contributor Author

Raised pytest-dev/pytest-base-url#39 to support dynamic scopes.

There is also a similar issue with pytest-playwright's browser_context_args fixture being fixed to session scope. This also needs to be dynamic.

@markhobson markhobson self-assigned this Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markhobson markhobson

Labels
technical Technical issue
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

gh-21 acteng/update-your-capital-schemes
1 participant
@markhobson