WIP Unexpected protocol: Extend trustedAppReferenceList to include more protocols #577 #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
william-stearns
requested changes
Apr 7, 2021
There was a problem hiding this comment.
Well done! This looks good. A few minor changes:
{"tcp", 80, []string{"http"}},
{"tcp", 443, []string{"ssl", "http,ssl", "ssl,http"}},
{"tcp", 25, []string{"smtp", "ssl", "smtp,ssl", "ssl,smtp"}},
{"tcp", 143, []string{"imap", "ssl", "imap,ssl", "ssl,imap"}},
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This expands the list of well known protocol/port/services. Given the potential impact on performance I only included a few that seem to appear most frequently, but it could easily be expanded further. All tests pass, however the intended result has not been verified as I do not know a way to view the data without the AC-Hunter interface.