Skip to content

Checkout V2: Update authorization from Basic to Bearer #5381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sinourain
Copy link
Contributor

@sinourain sinourain commented Jan 13, 2025

Start sending requests using http Auth:Bearer

This PR was previously reviewed here, however after 60-days notice was automatically closed by AM, therefore I request a new review.

Spreedly reference:
OPPS-23

Remote:
Finished in 307.82125 seconds.
114 tests, 280 assertions, 2 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
98.2456% passed

Unit:
Finished in 41.256327 seconds.
6155 tests, 81007 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
149.19 tests/s, 1963.50 assertions/s

RuboCop:
Inspecting 806 files
806 files inspected, no offenses detected

@sinourain sinourain force-pushed the OPPS-23_Checkoutv2-Update_Authorization_from_Basic_to_Bearer branch 2 times, most recently from 0a8b29b to 69e4057 Compare January 13, 2025 23:17
@sinourain sinourain requested review from a team and removed request for a team January 13, 2025 23:22
@sinourain sinourain marked this pull request as draft January 14, 2025 18:33
@sinourain
Copy link
Contributor Author

I moved the PR to draft because in a test I get the error: processing_channel_id

@sinourain sinourain force-pushed the OPPS-23_Checkoutv2-Update_Authorization_from_Basic_to_Bearer branch from 69e4057 to 7fc916a Compare April 3, 2025 15:27
@sinourain sinourain marked this pull request as ready for review April 3, 2025 15:27
@sinourain sinourain force-pushed the OPPS-23_Checkoutv2-Update_Authorization_from_Basic_to_Bearer branch from 7fc916a to 4180b1e Compare April 3, 2025 15:29
@sinourain sinourain requested a review from a team April 3, 2025 15:30
@almalee24
Copy link
Contributor

@sinourain theres a few failing remote tests

@sinourain sinourain force-pushed the OPPS-23_Checkoutv2-Update_Authorization_from_Basic_to_Bearer branch from 4180b1e to 6800764 Compare April 16, 2025 16:33
@sinourain
Copy link
Contributor Author

@sinourain theres a few failing remote tests

The following tests were failing:

CASE A:

test_successful_purchase_with_processing_data

This test is still failing, the error code found in the official documentation is:

aft_processor_not_matched | Account funding transactions (AFTs) are not configured. A matching processor was not found.

CASE B: The following tests were deleted because they are meaningless with the latest NAS/HUB platform changes.
test_successful_purchase_for_secret_key_basic_authorization_header
test_money_transfer_payout_reverts_to_credit_if_payout_sent_as_nil
test_money_transfer_payout_handles_blank_destination_address

CASE C: Since payout and destination are now required in the options, it was added and this way the test no longer fails.
test_successful_credit

@sinourain sinourain force-pushed the OPPS-23_Checkoutv2-Update_Authorization_from_Basic_to_Bearer branch 2 times, most recently from 635517a to aa89327 Compare April 16, 2025 17:02
Start sending requests using http Auth:Bearer

Spreedly reference:
[ECS-3487](https://spreedly.atlassian.net/browse/ECS-3487)

Unit:
66 tests, 403 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
2821.48 tests/s, 17228.11 assertions/s

Remote:
103 tests, 254 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
0.63 tests/s, 1.56 assertions/s
@sinourain sinourain force-pushed the OPPS-23_Checkoutv2-Update_Authorization_from_Basic_to_Bearer branch from aa89327 to dd12d1d Compare April 16, 2025 17:05
@sinourain sinourain requested a review from almalee24 April 16, 2025 22:04
@almalee24 almalee24 requested a review from a team April 18, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants