OPPS-335 Additional currencies for orbital gateway #5438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almalee24
reviewed
Mar 28, 2025
sinourain
suggested changes
Mar 31, 2025
almalee24
reviewed
Apr 2, 2025
almalee24
reviewed
Apr 2, 2025
| 'MWK' => '454', # Malawi Kwacha | ||
| 'MYR' => '458', # Malaysian Ringgit | ||
| 'MVR' => '462', # Maldive Rufiyaa | ||
| 'MRO' => '478', # Mauritania Ouguiya |
There was a problem hiding this comment.
There was a problem hiding this comment.
code for MRU is 929, whereas in doc, its mentioned as 478
almalee24
reviewed
Apr 2, 2025
almalee24
reviewed
Apr 2, 2025
| 'USD' => '840', # U.S. Dollar | ||
| 'UZS' => '860', # Uzbekistan Sum | ||
| 'VUV' => '548', # Vanuatu Vatu | ||
| 'VEB' => '862', # Venezuelan Bolivar |
There was a problem hiding this comment.
This needs to be VES. It used to be VEB but was replaced to VEF in 2018 then it was changed to VES.
There was a problem hiding this comment.
code for VES is 928 but in doc, 862 is mentioned for Venezuelan Bolivar
almalee24
reviewed
Apr 2, 2025
| 'VEB' => '862', # Venezuelan Bolivar | ||
| 'VND' => '704', # Vietnamese Dong | ||
| 'YER' => '886', # Yemeni Rial | ||
| 'ZMK' => '894', # Zambian Kwacha |
There was a problem hiding this comment.
This needs to be ZMW. These currency codes are confusing I do see ZWK but it looks like it was change to ZMW
There was a problem hiding this comment.
code for ZMW is is 967 but in doc its 894 for Zambian Kwacha
almalee24
reviewed
Apr 2, 2025
| 'VND' => '704', # Vietnamese Dong | ||
| 'YER' => '886', # Yemeni Rial | ||
| 'ZMK' => '894', # Zambian Kwacha | ||
| 'ZWD' => '716' # Zimbabwe Dollar |
There was a problem hiding this comment.
code for ZWL is is 932 but in doc its 716 for Zimbabwe Dollar
almalee24
approved these changes
Apr 3, 2025
ankurspreedly
force-pushed
the
OPPS-335_Add_support_for_more_currencies_in_oribtal_gateway
branch
from
165f5ac to
424fecd
Compare
almalee24
force-pushed
the
OPPS-335_Add_support_for_more_currencies_in_oribtal_gateway
branch
2 times, most recently
from
cb376cf to
812df7e
Compare
Remote Tests (11 failing, WIP) Finished in 286.595268 seconds. 137 tests, 552 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed 0.48 tests/s, 1.93 assertions/s
almalee24
force-pushed
the
OPPS-335_Add_support_for_more_currencies_in_oribtal_gateway
branch
from
812df7e to
0e5758a
Compare
almalee24
deleted the
OPPS-335_Add_support_for_more_currencies_in_oribtal_gateway
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add Support for additional currencies in Orbital Gateway
OPPS-335
Unit Tests
Finished in 1.478374 seconds.
154 tests, 929 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
104.17 tests/s, 628.39 assertions/s
Remote Tests (11 failing, WIP)
Finished in 286.595268 seconds.
137 tests, 552 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
0.48 tests/s, 1.93 assertions/s
Rubocop
809 files inspected, no offenses detected