Fix esm error on windows (#566)

* fix esm error on windows * release notes * renaming release note
actualbudget · Feb 6, 2025 · e1a694a · e1a694a
1 parent 8b49a25
commit e1a694a
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/src/app-gocardless/bank-factory.js b/src/app-gocardless/bank-factory.js
@@ -1,6 +1,6 @@
 import fs from 'node:fs';
 import path from 'node:path';
-import { fileURLToPath } from 'node:url';
+import { fileURLToPath, pathToFileURL } from 'node:url';
 
 import IntegrationBank from './banks/integration-bank.js';
 
@@ -14,7 +14,8 @@ async function loadBanks() {
 
   const imports = await Promise.all(
     bankHandlers.map((file) => {
-      return import(path.resolve(banksDir, file)).then(
+      const fileUrlToBank = pathToFileURL(path.resolve(banksDir, file)); // pathToFileURL for ESM compatibility
+      return import(fileUrlToBank.toString()).then(
         (handler) => handler.default,
       );
     }),

diff --git a/upcoming-release-notes/566.md b/upcoming-release-notes/566.md
@@ -0,0 +1,6 @@
+---
+category: Bugfix
+authors: [MikesGlitch]
+---
+
+Fix ESM bug on Windows when loading gocardless banks