Skip to content

Commit

Permalink
Explicitly disable 1Password on table inputs (#3674)
Browse files Browse the repository at this point in the history
* Explicitly disable 1Password on table inputs

* Add release notes

* Update packages/desktop-client/src/components/autocomplete/Autocomplete.tsx

Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>

---------

Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>
  • Loading branch information
greggroth and matt-fidd authored Oct 15, 2024
1 parent 3d9e90f commit 1a13e98
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,8 @@ function fireUpdate<T extends Item>(
}

function defaultRenderInput(props: ComponentProps<typeof Input>) {
return <Input {...props} />;
// data-1p-ignore disables 1Password autofill behaviour
return <Input data-1p-ignore {...props} />;
}

function defaultRenderItems<T extends Item>(
Expand Down
6 changes: 6 additions & 0 deletions upcoming-release-notes/3674.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
category: Bugfix
authors: [greggroth]
---

Fixes 1Password credit card autocomplete showing on the transactions table

0 comments on commit 1a13e98

Please sign in to comment.