code review

actualbudget · Feb 27, 2025 · 330fc08 · 330fc08
1 parent 458f8ea
commit 330fc08
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 23 deletions.
diff --git a/packages/sync-server/src/app-pluggyai/app-pluggyai.js b/packages/sync-server/src/app-pluggyai/app-pluggyai.js
@@ -107,7 +107,7 @@ app.post(
         }
 
         newTrans.date = getDate(transactionDate);
-        newTrans.payeeName = pluggyaiService.getPayeeName(trans);
+        newTrans.payeeName = getPayeeName(trans);
         newTrans.notes = trans.descriptionRaw || trans.description;
 
         let amountInCurrency = trans.amountInAccountCurrency ?? trans.amount;
@@ -184,3 +184,23 @@ function flattenObject(obj, prefix = '') {
 
   return result;
 }
+
+function getPayeeName(trans) {
+  if (trans.merchant && (trans.merchant.name || trans.merchant.businessName)) {
+    return trans.merchant.name || trans.merchant.businessName || '';
+  }
+
+  if (trans.paymentData) {
+    const { receiver, payer } = trans.paymentData;
+
+    if (trans.type === 'DEBIT' && receiver) {
+      return receiver.name || receiver.documentNumber?.value || '';
+    }
+
+    if (trans.type === 'CREDIT' && payer) {
+      return payer.name || payer.documentNumber?.value || '';
+    }
+  }
+
+  return '';
+}
diff --git a/packages/sync-server/src/app-pluggyai/pluggyai-service.js b/packages/sync-server/src/app-pluggyai/pluggyai-service.js
@@ -117,26 +117,4 @@ export const pluggyaiService = {
 
     return transactions;
   },
-  getPayeeName: trans => {
-    if (
-      trans.merchant &&
-      (trans.merchant.name || trans.merchant.businessName)
-    ) {
-      return trans.merchant.name || trans.merchant.businessName || '';
-    }
-
-    if (trans.paymentData) {
-      const { receiver, payer } = trans.paymentData;
-
-      if (trans.type === 'DEBIT' && receiver) {
-        return receiver.name || receiver.documentNumber?.value || '';
-      }
-
-      if (trans.type === 'CREDIT' && payer) {
-        return payer.name || payer.documentNumber?.value || '';
-      }
-    }
-
-    return '';
-  },
 };