Skip to content

Commit

Permalink
🐛 [Goals]: Fix notifications not showing for single category template…
Browse files Browse the repository at this point in the history
… applications (#4222)

* show broken transfers

* more detail

* feat: add step to fix splits for fixing transfers with categories that should not be there

* reword

* update the setting

* note

* lint

* typo

* another misspelling

* fix single notification

* note

* Update VRT

* run checks

---------

Co-authored-by: UnderKoen <koenvanstaveren@hotmail.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
  • Loading branch information
3 people authored Jan 23, 2025
1 parent 977657a commit 5448a5c
Show file tree
Hide file tree
Showing 8 changed files with 16 additions and 6 deletions.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
16 changes: 10 additions & 6 deletions packages/loot-core/src/client/queries/queriesSlice.ts
Original file line number Diff line number Diff line change
Expand Up @@ -618,6 +618,16 @@ export const applyBudgetAction = createAppAsyncThunk(
),
);
break;
case 'apply-single-category-template':
dispatch(
addNotification(
await send('budget/apply-single-template', {
month,
category: args.category,
}),
),
);
break;
case 'cleanup-goal-template':
dispatch(
addNotification(
Expand Down Expand Up @@ -670,12 +680,6 @@ export const applyBudgetAction = createAppAsyncThunk(
});
break;
}
case 'apply-single-category-template':
await send('budget/apply-single-template', {
month,
category: args.category,
});
break;
case 'apply-multiple-templates':
dispatch(
addNotification(
Expand Down
6 changes: 6 additions & 0 deletions upcoming-release-notes/4222.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
category: Bugfix
authors: [youngcw]
---

Fix notifications when applying to a single category

0 comments on commit 5448a5c

Please sign in to comment.