-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Performance - adding / removing budget items very slow #4045
Comments
Presumably this is because the entire db needs to be loaded to perform each action. I imagine that fixing this would mean refactoring to lazy-load where possible, and add loading states, though I've not looked into the codebase much myself so this is just a guess. Screen.Recording.2024-12-26.at.11.55.27.AM.mov |
Try resetting the budget cache |
Trying this now - any idea how long it should take? So far it's been about 30min & it's still spinning? |
1hour in, still working. I restarted the app, which loaded like normal (~15 seconds on load screen). Still having the same issue. |
Hmm. Something must be off. If you are using a server try redownloading. If not try exporting and reimporting. |
Any estimate on how long this process should take? It's currently importing, and has been spinning for ~8 min... (I'm on an M2 Mac w/ desktop app) |
Should be fast. I wonder if something is not happening right for M2. There is a build for Mac Arm, but maybe it struggles on M2 |
Yeah that seems possible. For reference, I was using the Arm build before, and just tried the X64 version, and it's even slower. (Works, but is worse.) |
Looks like I'm having the same issues running from source with |
Ok - ruling out platform. I'm seeing the same issue on a new PikaPods instance after importing my file. |
Maybe try resetting the cache after importing each account to see if that fixes it. You shouldn't have issues with the number of transactions you claimed unless you are an order of magnitude above what you originally said. |
Somewhat related issue. |
I am confused why several people have stated "should be fast" in their comment. Can anyone offer proof in the source code that the persistence layer is well-optimized? Doesn't this project use an embedded, single file based database? If that's the case I would say high-performance should not be expected here (without alot of optimization). I have seen similar performance issues when applying templates (takes upwards of 16-20s to apply a template). |
I have a hair under 7k transactions going back to 2017 (I imported from, YNAB). Applying templates to the whole budget(~40 categories) takes ~<1 second. The suggestion from youngcw to reset sync id solves most reports of slowness, have you tried that yet? If it persists consider opening a support thread in discord. |
I am also experiencing incredible slowness. I am running the client in an Edge web browser on a M1 MacBook Pro. The server is on my NAS in a docker container. I am running the latest version. I'm happy to provide any further details. Our budget data contains roughly 10 years of history. I have tried resetting the cache, but it didn't seem to make a difference. |
Have you reset the sync id? That usually speeds things up if you just did an import |
Just reset the sync id and that did speed things up quite a bit. Register updates were taking 10-20 seconds previously, and now seem to take around 5 seconds. I'm planning to start fresh so hoping by archiving years of data that will help improve this further. |
Here's some more details on the extreme slowness of updating an account register. This is still occurring after updating client and server versions to I've reset the sync id several times since initially experiencing this. It seems to alleviate the problem for a short time, but the slowness seems to accumulate the more register changes I make. This appears to be magnitudes more slow on my M1 Macbook Pro running in an Edge browser versus running on Safari on the iPhone. I have yet to try Safari on the MacBook, but will give that a shot later. I made a video of updating an imported transaction where I change the payee name, remove the description and select a category. 50 seconds after modifying the payee name, it prompts me with the option to merge the payee, which I select to merge. Afterwards, it's probably another 20-30 seconds to see the description changes apply (in the video you can see the original description appear and disappear a few times), and then about the same time for the caegory change to take. Then close to two minutes in, I see the server syncing the changes. Let me know if you'd like the video posted here or elsewhere. |
I have since switched to using Safari and the performance is a fantastic improvement. No lag or delay at all. Just wanted to mention if anyone else is using Edge (or possibly another chromium based broswer) on a M1 MacBook. |
Verified issue does not already exist?
What happened?
With a larger files, the application becomes very slow to load at various points.
Specific points I've seen are:
How can we reproduce the issue?
Expected: The category is added right away.
Actual: The application appears to do nothing for 10-20 seconds, then adds the category.
Where are you hosting Actual?
Desktop App (Electron)
What browsers are you seeing the problem on?
Desktop App (Electron)
Operating System
Mac OSX
The text was updated successfully, but these errors were encountered: