resets transaction search even if search text is not empty #4461

alecbakholdin · 2025-02-26T23:08:44Z

Resolves #4436

category: Bugfix
authors: [alecbakholdin]

Fixed bug where partially erasing search string would not reset search and result in incorrect search results.

netlify · 2025-02-26T23:09:02Z

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	`6b28f15`
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/67bfa0e5d96e4e00088e7a78
😎 Deploy Preview	https://deploy-preview-4461.demo.actualbudget.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions · 2025-02-26T23:10:13Z

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
17	7.01 MB → 7.01 MB (+3.59 kB)	+0.05%

Changeset

File	Δ	Size
`locale/fr.json`	📈 +3.57 kB (+4.15%)	85.85 kB → 89.42 kB
`home/runner/work/actual/actual/packages/loot-core/src/client/data-hooks/transactions.ts`	📈 +20 B (+0.32%)	6.17 kB → 6.19 kB

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset	File Size	% Changed
static/js/fr.js	85.85 kB → 89.42 kB (+3.57 kB)	+4.15%
static/js/index.js	4.35 MB → 4.35 MB (+20 B)	+0.00%

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
static/js/en-GB.js	99.33 kB	0%
static/js/de.js	115.06 kB	0%
static/js/en.js	103.19 kB	0%
static/js/nl.js	98.45 kB	0%
static/js/pt-BR.js	113.53 kB	0%
static/js/uk.js	111.11 kB	0%
static/js/indexeddb-main-thread-worker-e59fee74.js	13.5 kB	0%
static/js/workbox-window.prod.es5.js	5.69 kB	0%
static/js/resize-observer.js	18.37 kB	0%
static/js/BackgroundImage.js	122.29 kB	0%
static/js/useAccountPreviewTransactions.js	1.69 kB	0%
static/js/AppliedFilters.js	10.79 kB	0%
static/js/narrow.js	86.21 kB	0%
static/js/wide.js	102.9 kB	0%
static/js/ReportRouter.js	1.59 MB	0%

github-actions · 2025-02-26T23:10:14Z

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
1	1.34 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
kcab.worker.js	1.34 MB	0%

alecbakholdin · 2025-02-26T23:15:22Z

Steps to reproduce to verify correctness:

Go to preview site, create a transaction with some value in the notes e.g. "testnote"
Switch to mobile view by shrinking width
Go to Accounts > On Budget
Type "tttnote" => transaction does not show up
Erase characters until you have "t" left in the search bar => transaction shows up (this was previously broken)
Type "est" to make search bar show "test" => transaction shows up (this was previously broken)

coderabbitai · 2025-02-26T23:48:16Z

Walkthrough

The change modifies the behavior of the transaction search functionality by adding an extra call to resetQuery() within the useTransactionsSearch function. Previously, the hook only invoked resetQuery() when the search text was empty. With the update, resetQuery() is now executed before calling updateQuery every time a non-empty search text is provided, ensuring that the query is reset beforehand. This adjustment alters the control flow of the search logic without modifying any exported or public API declarations.

Suggested labels

:sparkles: Merged

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5214549 and 6b28f15.

⛔ Files ignored due to path filters (1)

upcoming-release-notes/4461.md is excluded by !**/*.md

📒 Files selected for processing (1)

packages/loot-core/src/client/data-hooks/transactions.ts (1 hunks)

🧰 Additional context used

🧠 Learnings (1)

packages/loot-core/src/client/data-hooks/transactions.ts (1)

Learnt from: joel-jeremy
PR: actualbudget/actual#3685
File: packages/loot-core/src/client/data-hooks/transactions.ts:32-88
Timestamp: 2024-11-10T16:45:25.627Z
Learning: In the React `useTransactions` hook defined in `packages/loot-core/src/client/data-hooks/transactions.ts`, changes to `options` (e.g., `options.pageCount`) should be applied on the next query without adding them to the `useEffect` dependency array, to avoid unnecessary rerenders when options change.

🔇 Additional comments (1)

packages/loot-core/src/client/data-hooks/transactions.ts (1)

320-320: Excellent bug fix for search reset behavior.

This change addresses issue #4436 by ensuring that every search operation starts with a clean slate. Previously, the search query was reset only when the search text was empty, causing incorrect results when users partially erased the search string. Adding resetQuery() before updating the query ensures consistent search behavior in all scenarios, even when modifying existing search text.

The implementation is straightforward and doesn't impact other functionality since resetQuery is already included in the dependency array of the useMemo hook.

✨ Finishing Touches

📝 Generate Docstrings

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

matt-fidd

Thanks for this

resets transaction search even if search text is not empty

739e5a2

actual-github-bot bot changed the title ~~resets transaction search even if search text is not empty~~ [WIP] resets transaction search even if search text is not empty Feb 26, 2025

actual-github-bot bot added the 🚧 WIP label Feb 26, 2025

added release notes

6b28f15

alecbakholdin changed the title ~~[WIP] resets transaction search even if search text is not empty~~ resets transaction search even if search text is not empty Feb 26, 2025

actual-github-bot bot added 🔍 Ready for review and removed 🚧 WIP labels Feb 26, 2025

matt-fidd approved these changes Feb 27, 2025

View reviewed changes

actual-github-bot bot added ✅ Approved and removed 🔍 Ready for review labels Feb 27, 2025

matt-fidd merged commit 94f9449 into actualbudget:master Feb 27, 2025
21 checks passed

actual-github-bot bot added ✨ Merged and removed ✅ Approved labels Feb 27, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

resets transaction search even if search text is not empty #4461

resets transaction search even if search text is not empty #4461

alecbakholdin commented Feb 26, 2025 •

edited

Loading

netlify bot commented Feb 26, 2025 •

edited

Loading

github-actions bot commented Feb 26, 2025 •

edited

Loading

github-actions bot commented Feb 26, 2025 •

edited

Loading

alecbakholdin commented Feb 26, 2025

coderabbitai bot commented Feb 26, 2025

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

matt-fidd left a comment

resets transaction search even if search text is not empty #4461

resets transaction search even if search text is not empty #4461

Conversation

alecbakholdin commented Feb 26, 2025 • edited Loading

category: Bugfix authors: [alecbakholdin]

netlify bot commented Feb 26, 2025 • edited Loading

✅ Deploy Preview for actualbudget ready!

github-actions bot commented Feb 26, 2025 • edited Loading

Bundle Stats — desktop-client

github-actions bot commented Feb 26, 2025 • edited Loading

Bundle Stats — loot-core

alecbakholdin commented Feb 26, 2025

coderabbitai bot commented Feb 26, 2025

Walkthrough

Suggested labels

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

matt-fidd left a comment

Choose a reason for hiding this comment

alecbakholdin commented Feb 26, 2025 •

edited

Loading

category: Bugfix
authors: [alecbakholdin]

netlify bot commented Feb 26, 2025 •

edited

Loading

github-actions bot commented Feb 26, 2025 •

edited

Loading

github-actions bot commented Feb 26, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)