From 055686eb0f4fbbccf879714cabadff8ec6864234 Mon Sep 17 00:00:00 2001 From: Josh Krebs Date: Mon, 21 Aug 2023 16:41:21 -0700 Subject: [PATCH 1/4] refactor MonthCountSelector to tsx --- ...hCountSelector.js => MonthCountSelector.tsx} | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) rename packages/desktop-client/src/components/budget/{MonthCountSelector.js => MonthCountSelector.tsx} (79%) diff --git a/packages/desktop-client/src/components/budget/MonthCountSelector.js b/packages/desktop-client/src/components/budget/MonthCountSelector.tsx similarity index 79% rename from packages/desktop-client/src/components/budget/MonthCountSelector.js rename to packages/desktop-client/src/components/budget/MonthCountSelector.tsx index d34dbf7a7f7..a31b627248b 100644 --- a/packages/desktop-client/src/components/budget/MonthCountSelector.js +++ b/packages/desktop-client/src/components/budget/MonthCountSelector.tsx @@ -6,7 +6,12 @@ import View from '../common/View'; import { useBudgetMonthCount } from './BudgetMonthCountContext'; -function Calendar({ color, onClick }) { +type CalendarProps = { + color: string; + onClick: () => void; +}; + +function Calendar({ color, onClick }: CalendarProps) { return ( void; +}; + +export function MonthCountSelector({ + maxMonths, + onChange, +}: MonthCountSelectorProps) { let { displayMax } = useBudgetMonthCount(); // It doesn't make sense to show anything if we can only fit one From fb666b2d0e0ceb20a65f1a85e690fc0cf0df968a Mon Sep 17 00:00:00 2001 From: Josh Krebs Date: Mon, 21 Aug 2023 17:23:15 -0700 Subject: [PATCH 2/4] refactor to pass tests --- .../src/components/budget/MonthCountSelector.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/desktop-client/src/components/budget/MonthCountSelector.tsx b/packages/desktop-client/src/components/budget/MonthCountSelector.tsx index a31b627248b..d5bba0f3a20 100644 --- a/packages/desktop-client/src/components/budget/MonthCountSelector.tsx +++ b/packages/desktop-client/src/components/budget/MonthCountSelector.tsx @@ -21,8 +21,8 @@ function Calendar({ color, onClick }: CalendarProps) { } type MonthCountSelectorProps = { - maxMonths?: number; - onChange: () => void; + maxMonths: number; + onChange: (value: number) => Promise; }; export function MonthCountSelector({ From 809dc3992ba05f71146cac21e3be13703205a65b Mon Sep 17 00:00:00 2001 From: Josh Krebs Date: Tue, 22 Aug 2023 10:31:13 -0700 Subject: [PATCH 3/4] add release notes --- upcoming-release-notes/1560.md | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 upcoming-release-notes/1560.md diff --git a/upcoming-release-notes/1560.md b/upcoming-release-notes/1560.md new file mode 100644 index 00000000000..4e4b62baf88 --- /dev/null +++ b/upcoming-release-notes/1560.md @@ -0,0 +1,6 @@ +--- +category: Maintenance +authors: [Jod929] +--- + +Refactor MonthCountSelector to tsx. \ No newline at end of file From 5cb7dfe107433732534f898ef5bcd4d2bb51986f Mon Sep 17 00:00:00 2001 From: Josh Krebs Date: Tue, 22 Aug 2023 10:35:18 -0700 Subject: [PATCH 4/4] update release note file name to match PR number --- upcoming-release-notes/{1560.md => 1565.md} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename upcoming-release-notes/{1560.md => 1565.md} (100%) diff --git a/upcoming-release-notes/1560.md b/upcoming-release-notes/1565.md similarity index 100% rename from upcoming-release-notes/1560.md rename to upcoming-release-notes/1565.md