[Feature] Add ability to create schedules from existing transactions #2222

xentara1 · 2024-01-13T13:49:55Z

#2221
Please let me know thoughts, or if you need any additional information

netlify · 2024-01-13T13:50:00Z

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	`9b23205`
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/65be7f07a067080008576267
😎 Deploy Preview	https://deploy-preview-2222.demo.actualbudget.org/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions · 2024-01-13T13:51:15Z

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
10	4.99 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
static/js/indexeddb-main-thread-worker-e59fee74.js	13.5 kB	0%
static/js/resize-observer.js	18.37 kB	0%
static/js/ButtonLink.js	379 B	0%
static/js/BackgroundImage.js	122.29 kB	0%
static/js/BalanceTooltip.js	6.06 kB	0%
static/js/AppliedFilters.js	28.99 kB	0%
static/js/narrow.js	80.18 kB	0%
static/js/wide.js	240.49 kB	0%
static/js/ReportRouter.js	1.84 MB	0%
static/js/index.js	2.65 MB	0%

github-actions · 2024-01-13T13:51:16Z

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
1	1.18 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
kcab.worker.js	1.18 MB	0%

MatissJanis · 2024-01-13T14:32:41Z

👋 Cool feature!

The list of all transaction options is getting quite long. Could you instead create a "create schedule" button in the "Link schedule" modal? That would solve the same problem (albeit with one more click, but I think that's fine since we don't expect people to be creating schedules often).

xentara1 · 2024-01-13T15:35:26Z

Adjusted let me know thoughts.

youngcw · 2024-01-13T15:47:26Z

Nice. I like that new placement of the button. We probably should add this to the docs in some way

xentara1 · 2024-01-13T15:54:55Z

Fixed lint's,
Not used typescript before so don't think its the best way hah.

xentara1 · 2024-01-13T15:55:16Z

Nice. I like that new placement of the button. We probably should add this to the docs in some way

Where do I update that?

youngcw · 2024-01-13T15:59:07Z

Fixed lint's, Not used typescript before so don't think its the best way hah.

if you run yarn lint --fix most lint issues will get taken care of. It looks like your fixes are fine though

youngcw · 2024-01-13T16:08:49Z

Where do I update that?

There is a repo for the docs and website https://github.com/actualbudget/docs

xentara1 · 2024-01-13T17:50:37Z

Where do I update that?

There is a repo for the docs and website https://github.com/actualbudget/docs

Added ->
actualbudget/docs#303

MatissJanis · 2024-01-14T16:23:46Z

Nice! This looks much better. But I'm seeing some usability problems:

after creating the schedule - it should auto-update the selected transaction so it would be added to the new schedule
after creating the schedule - all modals should be closed

Would you mind taking a look at these small issues? Also: please run yarn lint --fix

Let me know if I/we can help!

xentara1 · 2024-01-15T21:57:07Z

Makes sense, adjusted as per comments,
Removed a check on event as don't see why it is a must, let me know if I'm missing something

MatissJanis

UX looks and works great! Did a first pass code review. Some smaller issues, but some bigger. Overall looks pretty good. Thanks!

packages/desktop-client/src/components/schedules/ScheduleLink.tsx

packages/desktop-client/src/components/transactions/SelectedTransactions.jsx

packages/desktop-client/src/hooks/useSelected.tsx

packages/desktop-client/src/components/transactions/SimpleTransactionsTable.jsx

xentara1 · 2024-01-17T15:55:38Z

Updated all comments,
Let me know if you want me to resolve the conversation, not sure how it normally works for opensource,
When code reviewing at work, it annoys me when someone else resolves everything without me confirming,

# Conflicts: # packages/desktop-client/src/components/schedules/ScheduleLink.tsx

MatissJanis

We're getting very close! Noticed a few other small bugs and some small code issues. LMK what you think.

MatissJanis · 2024-02-03T14:57:29Z

packages/desktop-client/src/components/schedules/ScheduleDetails.jsx

+          if (fromTrans) {
+            action.transactions = action.transactions.filter(
+              x => x.id !== transaction.id,
+            );
+            action.transactions.unshift(transaction);
+          }


💬 suggestion: ‏Is this just sorting the transactions so a specific one would be always one the top? Could we instead use the sort operation for it and keep the input (action.transactions) immutable?

i.e. something along the lines of

return { ...state, transactions: action.transactions.sort((a, b) => { if (fromTrans) { // some custom sorting logic } return 0; }) }

Done, However as discussed this now means that if you adjust the details of the schedule, you can lose the transaction you are trying to link from.

MatissJanis · 2024-02-03T14:59:25Z

packages/desktop-client/src/components/schedules/ScheduleDetails.jsx

+        if (fromTrans) {
+          schedule._account = transaction.account;
+          schedule._amount = transaction.amount;
+          schedule._amountOp = 'is';
+          schedule._date = {
+            frequency: 'monthly',
+            start: transaction.date,
+            patterns: [],
+          };
+          schedule.name = payees[transaction.payee].name;
+          schedule._payee = transaction.payee;
+        }


💬 suggestion: ‏could we also follow immutability here?

i.e.

const schedule = fromTrans ? { // .. some custom schedule definition } : { // .. the default schedule definition };

Also: we are missing some parameters here. Some of the fields in the schedule modal appear without any values.

MatissJanis · 2024-02-03T15:00:00Z

packages/desktop-client/src/components/schedules/ScheduleDetails.jsx

+            start: transaction.date,
+            patterns: [],
+          };
+          schedule.name = payees[transaction.payee].name;


🔨 warning: ‏what if the transaction doesn't have a payee?

MatissJanis · 2024-02-03T15:00:56Z

packages/desktop-client/src/components/schedules/ScheduleDetails.jsx

+  const selectedInst = useSelected('transactions', state.transactions, [
+    transaction ? transaction.id : null,
+  ]);


💬 suggestion: ‏I'm not entirely sure what problems a null value here might cause in other parts of the product. It would be safer to do this:

Suggested change

const selectedInst = useSelected('transactions', state.transactions, [

transaction ? transaction.id : null,

]);

const selectedInst = useSelected('transactions', state.transactions, transaction ? [transaction.id] : []);

Like it makes, sense

MatissJanis · 2024-02-03T15:01:29Z

packages/desktop-client/src/components/schedules/ScheduleLink.tsx

 }: {
  actions: BoundActions;
  modalProps?: CommonModalProps;
  transactionIds: string[];
+  getTransaction: (tranID: string) => TransactionEntity;


🥜 nitpick: ‏no need to truncate the variable name

Suggested change

getTransaction: (tranID: string) => TransactionEntity;

getTransaction: (transactionId: string) => TransactionEntity;

MatissJanis · 2024-02-03T15:02:28Z

packages/desktop-client/src/components/schedules/ScheduleLink.tsx

+            style={{ marginLeft: 15, padding: '4px 10px' }}
+            onClick={onCreate}
+          >
+            <SvgAdd style={{ width: '20px', padding: '3px' }} />


🥜 nitpick: ‏

Suggested change

<SvgAdd style={{ width: '20px', padding: '3px' }} />

<SvgAdd style={{ width: 20, padding: 3 }} />

MatissJanis

LGTM! Thanks for being so patient and thanks for your contribution!

As discussed.. actualbudget/actual#2222 --------- Co-authored-by: xentara1 <xentara1@xentara1.com> Co-authored-by: alex Foreman <>

…ctualbudget#2222)

trafico-bot bot added the 🔍 Ready for Review label Jan 13, 2024

xentara1 mentioned this pull request Jan 13, 2024

Adding Create Schedule From Transaction actualbudget/docs#303

Merged

xentara1 added 11 commits January 15, 2024 21:57

Create Schedules from existing transactions

20c105c

Create Schedules from existing transactions

0a27c1b

Create Schedules from existing transactions

9ca4ff7

Create Schedules from existing transactions

0c16f0e

Create Schedules from existing transactions

b2905ac

Create Schedules from existing transactions

947d0ff

Create Schedules from existing transactions

4979a20

Create Schedules from existing transactions

714d887

Create Schedules from existing transactions

85b588d

Create Schedules from existing transactions

d91c18a

Add Model clear, and link transactions automatically

9a4a26b

xentara1 force-pushed the master branch from 7d438d0 to 9a4a26b Compare January 15, 2024 21:57

Merge branch 'master' into master

2e937ec

MatissJanis requested changes Jan 16, 2024

View reviewed changes

trafico-bot bot added the ⚠️ Changes requested Pull Request needs changes before it can be reviewed again label Jan 16, 2024

trafico-bot bot removed the 🔍 Ready for Review label Jan 16, 2024

Add Model clear, and link transactions automatically

3e17d1f

trafico-bot bot added 🔍 Ready for Review and removed ⚠️ Changes requested Pull Request needs changes before it can be reviewed again labels Jan 17, 2024

xentara1 added 7 commits January 23, 2024 20:27

Fixxing and simplifying

e70320f

Fixxing and simplifying

eeb90bc

Fixxing and simplifying

0e60fe7

Fixxing and simplifying

638b2a3

Fixxing and simplifying

7f8c6f0

Fixxing and simplifying

df5eb3f

Merge branch 'master' of https://github.com/actualbudget/actual

45e4ac4

# Conflicts: # packages/desktop-client/src/components/schedules/ScheduleLink.tsx

xentara1 requested a review from MatissJanis February 3, 2024 12:47

MatissJanis requested changes Feb 3, 2024

View reviewed changes

trafico-bot bot added ⚠️ Changes requested Pull Request needs changes before it can be reviewed again and removed 🔍 Ready for Review labels Feb 3, 2024

Fixxing and simplifying

9b23205

trafico-bot bot added 🔍 Ready for Review and removed ⚠️ Changes requested Pull Request needs changes before it can be reviewed again labels Feb 3, 2024

MatissJanis approved these changes Feb 3, 2024

View reviewed changes

MatissJanis merged commit 29a515f into actualbudget:master Feb 3, 2024
19 checks passed

trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed 🔍 Ready for Review labels Feb 3, 2024

youngcw mentioned this pull request Feb 8, 2024

[Feature] Add ability to create schedules from existing transactions #2221

Closed

2 tasks

youngcw pushed a commit to actualbudget/docs that referenced this pull request Feb 27, 2024

Adding Create Schedule From Transaction (#303)

6f42b9f

As discussed.. actualbudget/actual#2222 --------- Co-authored-by: xentara1 <xentara1@xentara1.com> Co-authored-by: alex Foreman <>

FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024

[Feature] Add ability to create schedules from existing transactions (a…

26eb4ee

…ctualbudget#2222)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Feature] Add ability to create schedules from existing transactions #2222

[Feature] Add ability to create schedules from existing transactions #2222

xentara1 commented Jan 13, 2024

netlify bot commented Jan 13, 2024 •

edited

Loading

github-actions bot commented Jan 13, 2024 •

edited

Loading

github-actions bot commented Jan 13, 2024 •

edited

Loading

MatissJanis commented Jan 13, 2024

xentara1 commented Jan 13, 2024

youngcw commented Jan 13, 2024

xentara1 commented Jan 13, 2024

xentara1 commented Jan 13, 2024

youngcw commented Jan 13, 2024 •

edited

Loading

youngcw commented Jan 13, 2024 •

edited

Loading

xentara1 commented Jan 13, 2024

MatissJanis commented Jan 14, 2024

xentara1 commented Jan 15, 2024

MatissJanis left a comment

xentara1 commented Jan 17, 2024

MatissJanis left a comment

MatissJanis Feb 3, 2024

xentara1 Feb 3, 2024

MatissJanis Feb 3, 2024

xentara1 Feb 3, 2024

MatissJanis Feb 3, 2024

xentara1 Feb 3, 2024

MatissJanis Feb 3, 2024

xentara1 Feb 3, 2024

MatissJanis Feb 3, 2024

xentara1 Feb 3, 2024

MatissJanis Feb 3, 2024

xentara1 Feb 3, 2024

MatissJanis left a comment

	getTransaction: (tranID: string) => TransactionEntity;
	getTransaction: (transactionId: string) => TransactionEntity;

	<SvgAdd style={{ width: '20px', padding: '3px' }} />
	<SvgAdd style={{ width: 20, padding: 3 }} />

[Feature] Add ability to create schedules from existing transactions #2222

[Feature] Add ability to create schedules from existing transactions #2222

Conversation

xentara1 commented Jan 13, 2024

netlify bot commented Jan 13, 2024 • edited Loading

✅ Deploy Preview for actualbudget ready!

github-actions bot commented Jan 13, 2024 • edited Loading

Bundle Stats — desktop-client

github-actions bot commented Jan 13, 2024 • edited Loading

Bundle Stats — loot-core

MatissJanis commented Jan 13, 2024

xentara1 commented Jan 13, 2024

youngcw commented Jan 13, 2024

xentara1 commented Jan 13, 2024

xentara1 commented Jan 13, 2024

youngcw commented Jan 13, 2024 • edited Loading

youngcw commented Jan 13, 2024 • edited Loading

xentara1 commented Jan 13, 2024

MatissJanis commented Jan 14, 2024

xentara1 commented Jan 15, 2024

MatissJanis left a comment

Choose a reason for hiding this comment

xentara1 commented Jan 17, 2024

MatissJanis left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MatissJanis left a comment

Choose a reason for hiding this comment

netlify bot commented Jan 13, 2024 •

edited

Loading

github-actions bot commented Jan 13, 2024 •

edited

Loading

github-actions bot commented Jan 13, 2024 •

edited

Loading

youngcw commented Jan 13, 2024 •

edited

Loading

youngcw commented Jan 13, 2024 •

edited

Loading