Fix schedule actions not applying and schedules paid the same day not showing #4171

matt-fidd · 2025-01-16T19:22:11Z

No description provided.

netlify · 2025-01-16T19:22:30Z

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	`1056705`
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/678961266e84ef0008a206ea
😎 Deploy Preview	https://deploy-preview-4171.demo.actualbudget.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions · 2025-01-16T19:23:47Z

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
13	6.43 MB → 6.43 MB (+533 B)	+0.01%

Changeset

File	Δ	Size
`node_modules/es-define-property/index.js`	📈 +210 B (+60.00%)	350 B → 560 B
`home/runner/work/actual/actual/packages/loot-core/src/client/data-hooks/transactions.ts`	📈 +246 B (+4.27%)	5.63 kB → 5.87 kB
`node_modules/has-property-descriptors/index.js`	📈 +9 B (+1.57%)	573 B → 582 B
`node_modules/call-bind/index.js`	📈 +9 B (+0.85%)	1.04 kB → 1.05 kB
`src/components/transactions/TransactionMenu.tsx`	📈 +11 B (+0.40%)	2.69 kB → 2.7 kB
`node_modules/define-data-property/index.js`	📈 +9 B (+0.39%)	2.24 kB → 2.25 kB
`src/components/modals/ScheduledTransactionMenuModal.tsx`	📈 +6 B (+0.21%)	2.75 kB → 2.75 kB
`src/components/schedules/PostsOfflineNotification.tsx`	📈 +6 B (+0.16%)	3.69 kB → 3.7 kB
`src/components/schedules/SchedulesTable.tsx`	📈 +16 B (+0.14%)	11.39 kB → 11.41 kB
`src/components/transactions/SelectedTransactionsButton.tsx`	📈 +11 B (+0.13%)	8.07 kB → 8.08 kB

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset	File Size	% Changed
static/js/index.js	4.19 MB → 4.19 MB (+522 B)	+0.01%
static/js/wide.js	100.98 kB → 100.99 kB (+11 B)	+0.01%

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
static/js/en.js	96.91 kB	0%
static/js/en-GB.js	96.9 kB	0%
static/js/useAccountPreviewTransactions.js	1.63 kB	0%
static/js/workbox-window.prod.es5.js	5.69 kB	0%
static/js/AppliedFilters.js	10.21 kB	0%
static/js/uk.js	120.47 kB	0%
static/js/BackgroundImage.js	122.29 kB	0%
static/js/indexeddb-main-thread-worker-e59fee74.js	13.5 kB	0%
static/js/resize-observer.js	18.37 kB	0%
static/js/narrow.js	84.3 kB	0%
static/js/ReportRouter.js	1.59 MB	0%

github-actions · 2025-01-16T19:23:48Z

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
1	1.33 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
kcab.worker.js	1.33 MB	0%

matt-fidd · 2025-01-16T19:42:35Z

/update-vrt

coderabbitai · 2025-01-16T19:59:23Z

Walkthrough

The pull request introduces consistent text changes across multiple components and files in the desktop client application. The modifications primarily focus on updating the text from "Post transaction" to "Post transaction today" and "Skip scheduled date" to "Skip next scheduled date" in various user interface elements. These changes span different components such as SchedulesPage, ScheduledTransactionMenuModal, PostsOfflineNotification, SchedulesTable, SelectedTransactionsButton, and TransactionMenu. Additionally, the transactions.ts file in the loot-core package includes updates to the usePreviewTransactions and isForPreview functions, enhancing date handling and status checks for transaction previews.

Possibly related PRs

Convert Mobile Transaction component to TransactionListItem + cleanup #3761: Modification of text from "Post transaction" to "Post transaction today" in ScheduledTransactionMenuModal.tsx
Add loading indicator when loading more transactions in mobile transaction list #3900: Introduction of loading indicator for transaction loading
show all occurrences of upcoming schedules within the upcoming period #4166: Enhanced handling of transaction statuses

Suggested labels

sparkles: Merged

Suggested reviewers

matt-fidd
youngcw

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 87428a7 and 1056705.

⛔ Files ignored due to path filters (1)

upcoming-release-notes/4171.md is excluded by !**/*.md

📒 Files selected for processing (7)

packages/desktop-client/e2e/page-models/schedules-page.js (1 hunks)
packages/desktop-client/src/components/modals/ScheduledTransactionMenuModal.tsx (1 hunks)
packages/desktop-client/src/components/schedules/PostsOfflineNotification.tsx (1 hunks)
packages/desktop-client/src/components/schedules/SchedulesTable.tsx (2 hunks)
packages/desktop-client/src/components/transactions/SelectedTransactionsButton.tsx (1 hunks)
packages/desktop-client/src/components/transactions/TransactionMenu.tsx (1 hunks)
packages/loot-core/src/client/data-hooks/transactions.ts (3 hunks)

✅ Files skipped from review due to trivial changes (5)

packages/desktop-client/src/components/schedules/PostsOfflineNotification.tsx
packages/desktop-client/src/components/modals/ScheduledTransactionMenuModal.tsx
packages/desktop-client/src/components/transactions/SelectedTransactionsButton.tsx
packages/desktop-client/src/components/schedules/SchedulesTable.tsx
packages/desktop-client/src/components/transactions/TransactionMenu.tsx

🧰 Additional context used

📓 Learnings (1)

packages/loot-core/src/client/data-hooks/transactions.ts (1)

Learnt from: matt-fidd
PR: actualbudget/actual#4166
File: packages/loot-core/src/client/data-hooks/transactions.ts:200-200
Timestamp: 2025-01-16T14:29:13.188Z
Learning: In the scheduled transactions implementation within `packages/loot-core/src/client/data-hooks/transactions.ts`, the `upcoming` flag is set based on `schedules.length > 0` to act as an override, where the first occurrence gets `false` and subsequent occurrences get `true`. This is intentional and should not be changed to date-based comparison.

🔇 Additional comments (5)

packages/desktop-client/e2e/page-models/schedules-page.js (1)

51-51: LGTM! Verify other E2E test files.

The text update from "Post transaction" to "Post transaction today" aligns with the UI changes and PR objectives.

Let's check if there are other E2E test files that might need similar updates:

✅ Verification successful

No other E2E test files need updating

The text update was only needed in schedules-page.js. The only other occurrence is in a test description in schedules.test.js which doesn't require modification as it's not UI text.
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:
#!/bin/bash
# Search for "Post transaction" in other E2E test files
rg -l "Post transaction" "packages/desktop-client/e2e"
Length of output: 112

Script:
#!/bin/bash
# Search for similar text patterns in E2E tests
rg -i "post.*transaction" "packages/desktop-client/e2e"
Length of output: 319
packages/loot-core/src/client/data-hooks/transactions.ts (4)

170-181: Improved handling of paid schedules on the current day.

The changes correctly prevent duplicate processing of schedules that are already paid today, fixing the issue with schedules paid the same day not showing properly.

187-187: LGTM! Consistent day increment.

The day increment is now consistently applied after processing each date.

324-324: LGTM! Added 'paid' status to preview conditions.

Including 'paid' status in isForPreview is consistent with the changes to handle paid schedules properly.

201-201: Verify the impact of ID format change and forceUpcoming condition.

Two notable changes:

The ID now includes a leading slash before the date

The forceUpcoming condition now considers paid status

The ID format change could affect code that parses these IDs.

Let's check for any ID parsing code:

The forceUpcoming change looks good as it aligns with the retrieved learning about the upcoming flag's intentional behavior.

Also applies to: 207-207

✅ Verification successful

ID format change is safe to proceed ✅

The ID format change (adding a slash before the date) has no impact on the codebase. The only usage of these preview IDs is:

Generation in client/data-hooks/transactions.ts

Simple prefix checking via indexOf('preview/') in shared/transactions.ts
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:
#!/bin/bash
# Search for preview ID parsing
rg "preview/.*split|split.*preview/" --type ts
Length of output: 48

Script:
#!/bin/bash
# Search for preview ID usage patterns
rg "preview/" --type ts -A 2

# Search for string operations near preview mentions
rg -B 2 -A 2 "preview.*\.(split|substring|replace|match|indexOf)" --type ts

# Search for preview ID declarations or assignments
ast-grep --pattern 'preview/$_'
Length of output: 896

Finishing Touches

📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

matt-fidd added 2 commits January 16, 2025 19:20

fix schedule actions and schedules paid on current day not displaying

4973969

note

aaf5a3f

actual-github-bot bot changed the title ~~Fix schedule actions not applying and schedules paid the same day not showing~~ [WIP] Fix schedule actions not applying and schedules paid the same day not showing Jan 16, 2025

actual-github-bot bot added the 🚧 WIP label Jan 16, 2025

matt-fidd mentioned this pull request Jan 16, 2025

make one month schedule upcoming length dynamic and add current month option #4168

Merged

change wording of post/skip actions

1056705

matt-fidd changed the title ~~[WIP] Fix schedule actions not applying and schedules paid the same day not showing~~ Fix schedule actions not applying and schedules paid the same day not showing Jan 16, 2025

actual-github-bot bot added 🔍 Ready for review and removed 🚧 WIP labels Jan 16, 2025

MatissJanis approved these changes Jan 16, 2025

View reviewed changes

actual-github-bot bot added ✅ Approved and removed 🔍 Ready for review labels Jan 16, 2025

matt-fidd merged commit 2a275b3 into actualbudget:master Jan 16, 2025
20 checks passed

actual-github-bot bot added ✨ Merged and removed ✅ Approved labels Jan 16, 2025

matt-fidd deleted the upcoming/fix-schedule-actions branch January 16, 2025 20:16

This was referenced Jan 17, 2025

add option to complete non-recurring schedules from transaction menu #4180

Merged

fix paid schedules showing as upcoming in the account #4188

Merged

coderabbitai bot mentioned this pull request Jan 29, 2025

fix first occurrence of some schedules moved after the weekend not showing in preview #4256

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix schedule actions not applying and schedules paid the same day not showing #4171

Fix schedule actions not applying and schedules paid the same day not showing #4171

matt-fidd commented Jan 16, 2025

netlify bot commented Jan 16, 2025 •

edited

Loading

github-actions bot commented Jan 16, 2025 •

edited

Loading

github-actions bot commented Jan 16, 2025 •

edited

Loading

matt-fidd commented Jan 16, 2025

coderabbitai bot commented Jan 16, 2025

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Fix schedule actions not applying and schedules paid the same day not showing #4171

Fix schedule actions not applying and schedules paid the same day not showing #4171

Conversation

matt-fidd commented Jan 16, 2025

netlify bot commented Jan 16, 2025 • edited Loading

✅ Deploy Preview for actualbudget ready!

github-actions bot commented Jan 16, 2025 • edited Loading

Bundle Stats — desktop-client

github-actions bot commented Jan 16, 2025 • edited Loading

Bundle Stats — loot-core

matt-fidd commented Jan 16, 2025

coderabbitai bot commented Jan 16, 2025

Walkthrough

Possibly related PRs

Suggested labels

Suggested reviewers

Finishing Touches

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

netlify bot commented Jan 16, 2025 •

edited

Loading

github-actions bot commented Jan 16, 2025 •

edited

Loading

github-actions bot commented Jan 16, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)