[Mobile] Fix "Category budget has been updated to ..." notification even when the budget was not updated

[joel-jeremy]

In edge, there is an issue in mobile where if you open the category budget modal and close it the "{Category} budget has been updated..." notification pops up even if the amount was not changed.

This PR is to fix FocusableAmountInput's onUpdate to only fire when amount was updated

Steps to reproduce:

1. Open mobile budget page
2. Click on a category's budget amount
3. Close the budget modal
4. (The notification shows up)

[netlify]

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	fdd72f0
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/678d8eaddc3fea000855fe1e
😎 Deploy Preview	https://deploy-preview-4200.demo.actualbudget.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[github-actions]

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
15	6.68 MB → 6.68 MB (+75 B)	+0.00%

Changeset

File	Δ	Size
src/components/mobile/transactions/FocusableAmountInput.tsx	📈 +97 B (+1.61%)	5.88 kB → 5.97 kB
src/components/mobile/transactions/TransactionEdit.jsx	📉 -22 B (-0.06%)	33.9 kB → 33.88 kB

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset	File Size	% Changed
static/js/index.js	4.28 MB → 4.28 MB (+75 B)	+0.00%

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
static/js/useAccountPreviewTransactions.js	1.63 kB	0%
static/js/AppliedFilters.js	10.52 kB	0%
static/js/nl.js	53.15 kB	0%
static/js/en.js	97.98 kB	0%
static/js/BackgroundImage.js	122.29 kB	0%
static/js/workbox-window.prod.es5.js	5.69 kB	0%
static/js/en-GB.js	96.03 kB	0%
static/js/pt-BR.js	107.8 kB	0%
static/js/resize-observer.js	18.37 kB	0%
static/js/narrow.js	84.83 kB	0%
static/js/indexeddb-main-thread-worker-e59fee74.js	13.5 kB	0%
static/js/wide.js	101.22 kB	0%
static/js/uk.js	118.39 kB	0%
static/js/ReportRouter.js	1.59 MB	0%

[github-actions]

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
1	1.33 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
kcab.worker.js	1.33 MB	0%

[coderabbitai]

Walkthrough

The pull request introduces modifications to the FocusableAmountInput.tsx and TransactionEdit.jsx files in the desktop client's mobile transactions components. In FocusableAmountInput.tsx, the onUpdate function now includes a condition to compare the new amount with the original amount before triggering updates. This change aims to reduce unnecessary update calls. In TransactionEdit.jsx, the onTotalAmountUpdate callback function has been modified to prevent clearing the active edit state when the transaction amount remains unchanged. The onBlur event is now used to clear the active edit state when the input loses focus, maintaining user interaction feedback.

Possibly related PRs

• Convert Mobile Transaction component to TransactionListItem + cleanup #3761: Changes to the TransactionEdit.jsx component related to transaction amount interactions
• Fix mobile transaction edit page's back button behavior #3905: Modifications to the TransactionEdit.jsx file affecting transaction editing functionality
• 🐛 (mobile) fix amount input requiring two clicks on safari mobile #4182: Addressing amount input field issues on mobile devices

Suggested labels

sparkles: Merged

Suggested reviewers

• matt-fidd
• youngcw

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cdbf3e0 and fdd72f0.

⛔ Files ignored due to path filters (1)

• upcoming-release-notes/4200.md is excluded by !**/*.md

📒 Files selected for processing (2)

• packages/desktop-client/src/components/mobile/transactions/FocusableAmountInput.tsx (1 hunks)
• packages/desktop-client/src/components/mobile/transactions/TransactionEdit.jsx (2 hunks)

🧰 Additional context used

📓 Learnings (1)

packages/desktop-client/src/components/mobile/transactions/TransactionEdit.jsx (1)

Learnt from: matt-fidd
PR: actualbudget/actual#4170
File: packages/desktop-client/src/components/mobile/transactions/TransactionEdit.jsx:570-581
Timestamp: 2025-01-17T12:00:27.629Z
Learning: The transaction amount conversion for income categories in TransactionEdit.jsx is intended as a quality-of-life feature to help users who forget to set the correct direction, not as a preventative measure. Users should still be able to manually enter negative amounts even for income categories.

⏰ Context from checks skipped due to timeout of 90000ms (6)

• GitHub Check: Functional
• GitHub Check: Visual regression
• GitHub Check: build (macos-latest)
• GitHub Check: build (windows-latest)
• GitHub Check: build (ubuntu-latest)
• GitHub Check: Analyze

🔇 Additional comments (3)

packages/desktop-client/src/components/mobile/transactions/FocusableAmountInput.tsx (1)

100-105: LGTM! Good optimization to prevent unnecessary updates.

The added condition ensures that onUpdate and onUpdateAmount callbacks are only triggered when there's an actual change in the amount value. This effectively addresses the issue mentioned in the PR objectives where notifications were appearing even when no changes were made.

packages/desktop-client/src/components/mobile/transactions/TransactionEdit.jsx (2)

589-589: LGTM! Correct dependency array.

The dependency array properly includes all dependencies used in the callback: onUpdateInner and transaction.

---

789-789: LGTM! Good addition of onBlur handler.

Adding onBlur={onClearActiveEdit} ensures proper cleanup of the active edit state when the input loses focus, maintaining a consistent user experience.

Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.