Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix react-hooks/exhaustive-deps error on usePayees.ts #4260

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

joel-jeremy
Copy link
Contributor

No description provided.

@actual-github-bot actual-github-bot bot changed the title Fix react-hooks/exhaustive-deps error on usePayees.ts [WIP] Fix react-hooks/exhaustive-deps error on usePayees.ts Jan 30, 2025
Copy link

netlify bot commented Jan 30, 2025

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 9797d14
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/679becd975f6fc0008a6f851
😎 Deploy Preview https://deploy-preview-4260.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Jan 30, 2025

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
15 6.71 MB → 6.71 MB (+238 B) +0.00%
Changeset
File Δ Size
src/hooks/usePayees.ts 📈 +238 B (+38.45%) 619 B → 857 B
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/index.js 4.29 MB → 4.29 MB (+238 B) +0.01%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/en.js 99.34 kB 0%
static/js/nl.js 79.76 kB 0%
static/js/en-GB.js 99.33 kB 0%
static/js/pt-BR.js 103.29 kB 0%
static/js/useAccountPreviewTransactions.js 1.69 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/workbox-window.prod.es5.js 5.69 kB 0%
static/js/AppliedFilters.js 10.52 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/uk.js 111.11 kB 0%
static/js/narrow.js 84.94 kB 0%
static/js/wide.js 102.8 kB 0%
static/js/ReportRouter.js 1.59 MB 0%

Copy link
Contributor

github-actions bot commented Jan 30, 2025

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.33 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.33 MB 0%

useEffect(() => {
if (!commonPayeesLoaded) {
if (isInitialMount && !commonPayeesLoaded) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: I wonder if we should change this to refetch whenever the payees are unloaded

Copy link
Contributor

github-actions bot commented Feb 7, 2025

👋 Hi! It looks like this PR has not had any changes for a week now. Would you like someone to review this PR? If so - please remove the "[WIP]" prefix from the PR title. That will let the community know that this PR is open for a review.

@github-actions github-actions bot added the Stale label Feb 7, 2025
@youngcw youngcw removed the Stale label Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants