🐛 Fix new proxy middleware dependency missing on prod build

[MikesGlitch]

The new proxy middleware was added as a dev dependency but imported in production as well.

The fix is to only import the dev dependency when in dev mode.

[netlify]

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	1e987a3
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/67b4879b6f11c900081c0b50
😎 Deploy Preview	https://deploy-preview-4400.demo.actualbudget.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[coderabbitai]

Walkthrough

The changes in this pull request update how the http-proxy-middleware package is imported and utilized within the application. Instead of importing the createProxyMiddleware function statically at the top of the file, it is now dynamically imported within a development-specific block. This modification allows the middleware to be treated as a development dependency, which can help reduce the production package size. Functionality remains unchanged, as the same configuration parameters are passed when calling httpProxyMiddleware.createProxyMiddleware. Additionally, the static import statement for createProxyMiddleware has been removed in favor of an asynchronous import approach, reflecting an adjustment in the middleware loading process while preserving the original proxy logic.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7a252d0 and 1e987a3.

⛔ Files ignored due to path filters (1)

• upcoming-release-notes/4400.md is excluded by !**/*.md

📒 Files selected for processing (1)

• packages/sync-server/src/app.js (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (7)

• GitHub Check: Visual regression
• GitHub Check: build (macos-latest)
• GitHub Check: build (windows-latest)
• GitHub Check: build (ubuntu-latest)
• GitHub Check: Analyze
• GitHub Check: Build Docker image (alpine)
• GitHub Check: Build Docker image (ubuntu)

🔇 Additional comments (2)

packages/sync-server/src/app.js (2)

82-82: LGTM! The proxy middleware is now correctly imported as a dev dependency.

The change successfully makes the proxy middleware a development-only dependency while maintaining the same functionality.

---

78-79:

❓ Verification inconclusive

Verify top-level await support in the project configuration.

The dynamic import is correctly placed within the development block. However, since this code uses top-level await, ensure that the project is configured to support ES modules with top-level await.

Run the following script to check the project configuration:

---

🏁 Script executed:

#!/bin/bash
# Description: Check package.json for module type and Node.js version requirements

# Check if package.json exists and contains "type": "module"
fd -t f "package.json" -x jq -r '.type'

# Check Node.js version requirement
fd -t f "package.json" -x jq -r '.engines.node'

Length of output: 83

---

Below is a new shell script to extract and inspect the essential parts of your package.json for ES module configuration. Please run the script and verify that the package.json includes a "type": "module" field (or otherwise enables ES modules), and that any specified Node.js version supports top-level await:

Ensure project configuration supports top-level await

The dynamic import of http-proxy-middleware in packages/sync-server/src/app.js (lines 78–79) is correctly placed within the development block. However, because this code relies on top-level await, please confirm that the project is configured for ES modules—specifically, that package.json includes a "type": "module" setting (or another means of enabling ES modules) and that the Node.js version meets the necessary requirements.

---

🏁 Script executed:

[run_scripts]
#!/bin/bash
echo "Verifying package.json for ES module settings and Node.js engine requirements:"
if [ -f package.json ]; then
  jq '{type, engines}' package.json || echo "Failed to parse package.json using jq"
else
  echo "package.json not found"
fi

Length of output: 369

---

Below is a revised review comment with an additional instruction to verify the package configuration in the relevant package folder:

---

Confirm ES module configuration for top-level await

The dynamic import of http-proxy-middleware is correctly scoped within the development block. However, because it relies on top-level await, please ensure that the application is set up to support ES modules. Since the root package.json wasn’t found, verify that the packages/sync-server package includes its own package.json with the necessary settings. In particular:

• Confirm that a package.json exists in the packages/sync-server directory.
• Verify that it includes "type": "module".
• Check that the Node.js version specified in "engines" meets the requirements for top-level await.

To help with this, please run the following shell script in the repository:

Once confirmed, if any adjustments are needed (e.g., adding the "type": "module" field or updating the Node engine version), please address these to ensure top-level await works as expected.

---

🏁 Script executed:

[run_scripts]
#!/bin/bash
echo "Checking for package.json in packages/sync-server and its ES module configuration:"
PACKAGE_JSON="packages/sync-server/package.json"
if [ -f "$PACKAGE_JSON" ]; then
  echo "Found package.json at $PACKAGE_JSON:"
  jq '{type, engines}' "$PACKAGE_JSON" || echo "Error parsing package.json"
else
  echo "No package.json found in packages/sync-server directory."
fi

Length of output: 515

---

Ensure proper ES module configuration for top-level await support

The dynamic import of http-proxy-middleware (using top-level await) appears to be correctly placed inside the development block. However, since no package.json was found in the packages/sync-server directory, please verify that the overall project is configured correctly. In many monorepo setups, the ES module configuration may reside in the repository’s root package.json. Please confirm that:

• A root-level package.json exists and includes "type": "module".
• The engines.node field (if specified) meets the requirements for top-level await.
• Alternatively, if packages/sync-server is expected to have its own package.json, add the necessary configuration there.

This manual verification is critical to ensure that the use of top-level await is supported in your runtime environment.

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.