-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] bump deps to most recent patch versions #4412
Conversation
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller
Unchanged No assets were unchanged |
All worked smoothly here apart from
adm-zip
which breaks after0.5.12
(only 4 patches behind latest though) because process.versions is set to{}
instead of unset in the browser. I think it's caused by webpack but it's not the intended behaviour (adm-zip tries to guard against this for browser environments), I've opened cthackers/adm-zip#551 upstream to fix.This is prep for bumping more deps, but with the next ones being minor/major changes with potential breaking changes they'll be separated into more PRs.
Tested fairly thoroughly, I think if it gets through CI there should be minimal risk here.