Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bank-factory.js add bank to BANKS_WITH_LIMITED_HISTORY #4416

Merged
merged 3 commits into from
Mar 1, 2025

Conversation

Th3Heavy
Copy link
Contributor

add bank 90 days limit history:
INDUSTRIEL_CMCIFRPAXXX
QONTO_QNTOFRP1

add bank  90 days limit history:
INDUSTRIEL_CMCIFRPAXXX
QONTO_QNTOFRP1
@actual-github-bot actual-github-bot bot changed the title Update bank-factory.js [WIP] Update bank-factory.js Feb 20, 2025
Copy link

netlify bot commented Feb 20, 2025

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 94d2afd
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/67b72f858504c90008fda72e
😎 Deploy Preview https://deploy-preview-4416.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Th3Heavy Th3Heavy changed the title [WIP] Update bank-factory.js [WIP] Update bank-factory.js add bank to BANKS_WITH_LIMITED_HISTORY Feb 20, 2025
Copy link
Contributor

👋 Hi! It looks like this PR has not had any changes for a week now. Would you like someone to review this PR? If so - please remove the "[WIP]" prefix from the PR title. That will let the community know that this PR is open for a review.

@github-actions github-actions bot added the Stale label Feb 28, 2025
@matt-fidd matt-fidd changed the title [WIP] Update bank-factory.js add bank to BANKS_WITH_LIMITED_HISTORY Update bank-factory.js add bank to BANKS_WITH_LIMITED_HISTORY Mar 1, 2025
@matt-fidd matt-fidd removed the Stale label Mar 1, 2025
Copy link
Contributor

@matt-fidd matt-fidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this

Copy link
Contributor

coderabbitai bot commented Mar 1, 2025

Walkthrough

The changes introduce two additional entries to the list of banks identified as having limited transaction history. Specifically, the updates extend the set of banks recognized by the system in the relevant module without altering any existing functionality or the public API. No logic or structural modifications were made beyond appending these new bank identifiers.

Suggested labels

:sparkles: Merged

Suggested reviewers

  • youngcw
  • joel-jeremy

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8d3b046 and 94d2afd.

⛔ Files ignored due to path filters (1)
  • upcoming-release-notes/4416.md is excluded by !**/*.md
📒 Files selected for processing (1)
  • packages/sync-server/src/app-gocardless/bank-factory.js (2 hunks)
🔇 Additional comments (1)
packages/sync-server/src/app-gocardless/bank-factory.js (1)

56-56: Changes look good - successfully added new banks to limited history list.

The two new entries to BANKS_WITH_LIMITED_HISTORY are correctly formatted and follow the same pattern as existing entries. This change aligns perfectly with the PR objective of adding 'INDUSTRIEL_CMCIFRPAXXX' and 'QONTO_QNTOFRP1' to the list of banks with a 90-day limit on transaction history.

Also applies to: 72-72

✨ Finishing Touches
  • 📝 Generate Docstrings

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@matt-fidd matt-fidd merged commit e91f8e7 into actualbudget:master Mar 1, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants