-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] [For Feedback] Update Dark theme with official Actual brand colors #4450
Open
joel-jeremy
wants to merge
8
commits into
master
Choose a base branch
from
dark-theme-with-brand-colors
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+94
−64
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
d047ba5
Update dark theme with official Actual brand colors
joel-jeremy ff09e95
Update VRT
github-actions[bot] 1816e69
Update colors
joel-jeremy e7ba870
Update colors
joel-jeremy 40a6df7
Update development color
joel-jeremy 975289c
Update account row color
joel-jeremy 945aa74
Update colors
joel-jeremy ee36227
Update VRT
github-actions[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+136 Bytes
(100%)
...dividual-account-page-and-checks-that-filtering-is-working-2-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+17 Bytes
(100%)
...dividual-account-page-and-checks-that-filtering-is-working-5-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-139 Bytes
(100%)
...dividual-account-page-and-checks-that-filtering-is-working-8-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1 KB
(100%)
...apshots/Accounts-Import-Transactions-import-csv-file-twice-2-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+50 Bytes
(100%)
...s-Import-Transactions-imports-transactions-from-a-CSV-file-2-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.57 KB
(100%)
.../e2e/accounts.test.ts-snapshots/Accounts-closes-an-account-2-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-269 Bytes
(100%)
...es-a-new-account-and-views-the-initial-balance-transaction-2-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+107 Bytes
(100%)
...cking--321fd-ed-amount-opens-the-budget-summary-menu-modal-2-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+249 Bytes
(100%)
...cking--6ab37-roup-name-opens-the-category-group-menu-modal-1-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+236 Bytes
(100%)
...cking--bed18-in-the-page-header-opens-the-month-menu-modal-1-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+65 Bytes
(100%)
...cking--ff568-l-redirects-to-the-category-transactions-page-2-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+175 Bytes
(100%)
...t-clicking-the-category-name-opens-the-category-menu-modal-1-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+65 Bytes
(100%)
...cking--57d88-l-redirects-to-the-category-transactions-page-2-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+270 Bytes
(100%)
...cking--5f098-roup-name-opens-the-category-group-menu-modal-1-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+245 Bytes
(100%)
...cking--b1562-in-the-page-header-opens-the-month-menu-modal-1-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+170 Bytes
(100%)
...t-clicking-the-category-name-opens-the-category-menu-modal-1-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-192 Bytes
(100%)
...tion-available-funds-overspent-budgeted-and-for-next-month-2-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-145 Bytes
(100%)
...est.ts-snapshots/Budget-transfer-funds-to-another-category-2-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-35.7 KB
(94%)
...rding.test.ts-snapshots/Onboarding-checks-the-page-visuals-2-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-32.8 KB
(95%)
...rding.test.ts-snapshots/Onboarding-checks-the-page-visuals-5-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.24 KB
(100%)
...stom-reports-Switches-to-Area-Graph-and-checks-the-visuals-2-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+705 Bytes
(100%)
...ustom-reports-Switches-to-Bar-Graph-and-checks-the-visuals-2-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-32 Bytes
(100%)
...stom-reports-Switches-to-Data-Table-and-checks-the-visuals-2-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+889 Bytes
(100%)
...tom-reports-Switches-to-Donut-Graph-and-checks-the-visuals-2-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+472 Bytes
(100%)
...stom-reports-Switches-to-Line-Graph-and-checks-the-visuals-2-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+27 Bytes
(100%)
...reports-Validates-that-show-labels-button-shows-the-labels-2-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+631 Bytes
(100%)
...alidates-that-show-legend-button-shows-the-legend-side-bar-2-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+253 Bytes
(100%)
...ports-Validates-that-show-summary-button-shows-the-summary-2-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+63 Bytes
(100%)
...ts-snapshots/Reports-loads-net-worth-and-cash-flow-reports-2-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
-846 Bytes
(99%)
.../e2e/rules.test.ts-snapshots/Rules-checks-the-page-visuals-2-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
-904 Bytes
(99%)
...e-and-makes-sure-it-is-applied-when-creating-a-transaction-2-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
-1.97 KB
(98%)
...e-and-makes-sure-it-is-applied-when-creating-a-transaction-5-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
-1.94 KB
(98%)
...e-and-makes-sure-it-is-applied-when-creating-a-transaction-2-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
-215 Bytes
(100%)
...edules.test.ts-snapshots/Schedules-checks-the-page-visuals-2-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
-467 Bytes
(99%)
...new-schedule-posts-the-transaction-and-later-completes-it-11-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
-1.17 KB
(99%)
...new-schedule-posts-the-transaction-and-later-completes-it-14-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
-591 Bytes
(99%)
...-new-schedule-posts-the-transaction-and-later-completes-it-2-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
-493 Bytes
(99%)
...-new-schedule-posts-the-transaction-and-later-completes-it-5-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
-2.41 KB
(98%)
...-new-schedule-posts-the-transaction-and-later-completes-it-8-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
-721 Bytes
(98%)
...ts/Mobile-Settings-checks-that-settings-page-can-be-opened-5-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
-1.84 KB
(98%)
...ettings.test.ts-snapshots/Settings-checks-the-page-visuals-2-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+90 Bytes
(100%)
...a-categorized-transaction-from-accounts-uncategorized-page-2-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+95 Bytes
(100%)
...e-Transactions-creates-a-transaction-from-accounts-id-page-1-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+149 Bytes
(100%)
...obile-Transactions-creates-a-transaction-via-footer-button-1-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
-47 Bytes
(100%)
...obile-Transactions-creates-a-transaction-via-footer-button-4-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+145 Bytes
(100%)
...obile-Transactions-creates-a-transaction-via-footer-button-5-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+248 Bytes
(100%)
...uncategorized-transaction-from-accounts-uncategorized-page-2-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
-1.73 KB
(98%)
...ons.test.ts-snapshots/Transactions-checks-the-page-visuals-2-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
-1.52 KB
(99%)
...ts-snapshots/Transactions-creates-a-split-test-transaction-2-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
-1.83 KB
(98%)
....test.ts-snapshots/Transactions-creates-a-test-transaction-2-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
-2.07 KB
(98%)
...snapshots/Transactions-creates-a-transfer-test-transaction-2-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
-1.64 KB
(98%)
...snapshots/Transactions-creates-a-transfer-test-transaction-5-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+38 Bytes
(100%)
...ts-snapshots/Transactions-filters-transactions-by-category-2-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
-52 Bytes
(99%)
...ts-snapshots/Transactions-filters-transactions-by-category-5-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
-2.56 KB
(98%)
...ts-snapshots/Transactions-filters-transactions-by-category-8-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1 Byte
(100%)
...est.ts-snapshots/Transactions-filters-transactions-by-date-2-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
-261 Bytes
(100%)
...est.ts-snapshots/Transactions-filters-transactions-by-date-8-chromium-linux.png
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The balance amount color here is messing with my eyes and is hard to read.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we would need to change the background colors to be able to use the brand color in the dark theme to improve contrast and readability
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the color changes become more extensive, it should be considered to clone the current scheme to preserve it. Labelled "Dark (legacy)" or something.