Resolves #4429 crash where clicking "manage payees" with an empty payee then clicking dropdown #4462

alecbakholdin · 2025-02-26T23:43:56Z

When clicking "manage payees" from an empty payee:

Notice below that the checkbox in the top left of the table is selected even though there are no checked payees. This is because an undefined payee has been set during the navigate() call.

clicking the dropdown above the table would result in an unrecoverable crash:

After fix:

netlify · 2025-02-26T23:44:14Z

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	`49e7eab`
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/67bfa73ef1835500080074aa
😎 Deploy Preview	https://deploy-preview-4462.demo.actualbudget.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions · 2025-02-26T23:45:16Z

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
17	7.01 MB → 7.01 MB (+3.57 kB)	+0.05%

Changeset

File	Δ	Size
`locale/fr.json`	📈 +3.57 kB (+4.15%)	85.85 kB → 89.42 kB
`src/components/transactions/TransactionList.jsx`	📈 +6 B (+0.10%)	5.77 kB → 5.78 kB

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset	File Size	% Changed
static/js/fr.js	85.85 kB → 89.42 kB (+3.57 kB)	+4.15%
static/js/AppliedFilters.js	10.79 kB → 10.8 kB (+6 B)	+0.05%

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
static/js/en-GB.js	99.33 kB	0%
static/js/de.js	115.06 kB	0%
static/js/en.js	103.19 kB	0%
static/js/nl.js	98.45 kB	0%
static/js/pt-BR.js	113.53 kB	0%
static/js/uk.js	111.11 kB	0%
static/js/indexeddb-main-thread-worker-e59fee74.js	13.5 kB	0%
static/js/workbox-window.prod.es5.js	5.69 kB	0%
static/js/resize-observer.js	18.37 kB	0%
static/js/BackgroundImage.js	122.29 kB	0%
static/js/useAccountPreviewTransactions.js	1.69 kB	0%
static/js/narrow.js	86.21 kB	0%
static/js/wide.js	102.9 kB	0%
static/js/ReportRouter.js	1.59 MB	0%
static/js/index.js	4.35 MB	0%

github-actions · 2025-02-26T23:45:17Z

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
1	1.34 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
kcab.worker.js	1.34 MB	0%

coderabbitai · 2025-02-26T23:48:31Z

Walkthrough

The changes update the onManagePayees callback within the TransactionList component. The function now includes a conditional statement that checks if the provided id is truthy before navigating to the /payees route with the selectedPayee state set to that id. If the id is falsy, the navigation action is not executed. This modification adds an extra validation step, thereby refining the decision-making process for route navigation. No changes have been made to the declarations of exported or public entities.

Suggested labels

:sparkles: Merged

Suggested reviewers

youngcw
joel-jeremy

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5214549 and 49e7eab.

⛔ Files ignored due to path filters (1)

upcoming-release-notes/4462.md is excluded by !**/*.md

📒 Files selected for processing (1)

packages/desktop-client/src/components/transactions/TransactionList.jsx (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (4)

GitHub Check: Functional
GitHub Check: Visual regression
GitHub Check: build (windows-latest)
GitHub Check: build (ubuntu-latest)

🔇 Additional comments (1)

packages/desktop-client/src/components/transactions/TransactionList.jsx (1)

221-226: Safe handling of empty payee IDs - good fix!

This change addresses the crash issue described in PR #4462. By adding a conditional check to only include the state object when id exists, the code prevents setting an undefined payee during navigation, which was causing the dropdown to crash.

The fix is simple and effective, ensuring that the navigation state only includes a selectedPayee when there's a valid ID to use.

✨ Finishing Touches

📝 Generate Docstrings

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

matt-fidd

LGTM! Thanks for this

Alec Bakholdin added 2 commits February 26, 2025 18:37

added release notes

8a7d58c

only set payee in state on page navigation if payee id is present

49e7eab

actual-github-bot bot changed the title ~~Resolves #4429 crash where clicking "manage payees" with an empty payee then clicking dropdown~~ [WIP] Resolves #4429 crash where clicking "manage payees" with an empty payee then clicking dropdown Feb 26, 2025

actual-github-bot bot added the 🚧 WIP label Feb 26, 2025

alecbakholdin changed the title ~~[WIP] Resolves #4429 crash where clicking "manage payees" with an empty payee then clicking dropdown~~ Resolves #4429 crash where clicking "manage payees" with an empty payee then clicking dropdown Feb 26, 2025

actual-github-bot bot added 🔍 Ready for review and removed 🚧 WIP labels Feb 26, 2025

matt-fidd approved these changes Feb 27, 2025

View reviewed changes

actual-github-bot bot added ✅ Approved and removed 🔍 Ready for review labels Feb 27, 2025

matt-fidd linked an issue Feb 27, 2025 that may be closed by this pull request

[Bug]: Clicking arrow in Payee when Managing Payees crashes app #4429

Closed

1 task

matt-fidd merged commit a72fd74 into actualbudget:master Feb 27, 2025
21 checks passed

actual-github-bot bot added ✨ Merged and removed ✅ Approved labels Feb 27, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Resolves #4429 crash where clicking "manage payees" with an empty payee then clicking dropdown #4462

Resolves #4429 crash where clicking "manage payees" with an empty payee then clicking dropdown #4462

alecbakholdin commented Feb 26, 2025

netlify bot commented Feb 26, 2025 •

edited

Loading

github-actions bot commented Feb 26, 2025

github-actions bot commented Feb 26, 2025

coderabbitai bot commented Feb 26, 2025

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

matt-fidd left a comment

Resolves #4429 crash where clicking "manage payees" with an empty payee then clicking dropdown #4462

Resolves #4429 crash where clicking "manage payees" with an empty payee then clicking dropdown #4462

Conversation

alecbakholdin commented Feb 26, 2025

netlify bot commented Feb 26, 2025 • edited Loading

✅ Deploy Preview for actualbudget ready!

github-actions bot commented Feb 26, 2025

Bundle Stats — desktop-client

github-actions bot commented Feb 26, 2025

Bundle Stats — loot-core

coderabbitai bot commented Feb 26, 2025

Walkthrough

Suggested labels

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

matt-fidd left a comment

Choose a reason for hiding this comment

netlify bot commented Feb 26, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)