Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves #4429 crash where clicking "manage payees" with an empty payee then clicking dropdown #4462

Merged
merged 2 commits into from
Feb 27, 2025
Merged

Resolves #4429 crash where clicking "manage payees" with an empty payee then clicking dropdown #4462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a7d58c
added release notes
Feb 26, 2025
49e7eab
only set payee in state on page navigation if payee id is present
Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/desktop-client/src/components/transactions/TransactionList.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ export function TransactionList({

const onManagePayees = useCallback(
id => {
navigate('/payees', { state: { selectedPayee: id } });
navigate('/payees', id && { state: { selectedPayee: id } });
},
[navigate],
);
Expand Down
6 changes: 6 additions & 0 deletions upcoming-release-notes/4462.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
category: Bugfix
authors: [alecbakholdin]
---

Fixed bug where navigating to payees page by clicking "manage payees" with an empty payee from a transaction would result in a crash.