fix #4445 #4468

youngcw · 2025-02-27T15:36:49Z

There would be a warning on a already "clean" budget. This should skip the warning if "clean" and have a green message instead.

fixes #4445

netlify · 2025-02-27T15:37:05Z

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	`018a93c`
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/67c08c6a75a5f40008915157
😎 Deploy Preview	https://deploy-preview-4468.demo.actualbudget.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions · 2025-02-27T15:38:26Z

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
18	7.07 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
static/js/es.js	60.58 kB	0%
static/js/fr.js	88.87 kB	0%
static/js/nl.js	97.78 kB	0%
static/js/en.js	103.18 kB	0%
static/js/en-GB.js	98.67 kB	0%
static/js/pt-BR.js	112.83 kB	0%
static/js/de.js	114.35 kB	0%
static/js/resize-observer.js	18.37 kB	0%
static/js/indexeddb-main-thread-worker-e59fee74.js	13.5 kB	0%
static/js/workbox-window.prod.es5.js	5.69 kB	0%
static/js/uk.js	111.11 kB	0%
static/js/BackgroundImage.js	122.29 kB	0%
static/js/narrow.js	86.21 kB	0%
static/js/wide.js	102.9 kB	0%
static/js/useAccountPreviewTransactions.js	1.69 kB	0%
static/js/AppliedFilters.js	10.8 kB	0%
static/js/ReportRouter.js	1.59 MB	0%
static/js/index.js	4.35 MB	0%

github-actions · 2025-02-27T15:38:27Z

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
1	1.34 MB → 1.34 MB (+64 B)	+0.00%

Changeset

File	Δ	Size
`packages/loot-core/src/server/budget/cleanup-template.ts`	📈 +171 B (+1.30%)	12.87 kB → 13.04 kB

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset	File Size	% Changed
kcab.worker.js	1.34 MB → 1.34 MB (+64 B)	+0.00%

Smaller

No assets were smaller

Unchanged

No assets were unchanged

coderabbitai · 2025-02-27T15:56:01Z

Walkthrough

The changes modify the logic within the processCleanup function. The condition that previously checked if budgetAvailable was less than or equal to zero has been updated to check if it is strictly less than zero. Additionally, a new condition now handles the scenario where budgetAvailable equals zero by returning a message indicating that all categories were up to date. No changes were made to the exported or public entities.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ac7e446 and 018a93c.

📒 Files selected for processing (1)

packages/loot-core/src/server/budget/cleanup-template.ts (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

packages/loot-core/src/server/budget/cleanup-template.ts

⏰ Context from checks skipped due to timeout of 90000ms (4)

GitHub Check: Visual regression
GitHub Check: Functional
GitHub Check: build (windows-latest)
GitHub Check: build (ubuntu-latest)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 398ada0 and ac7e446.

⛔ Files ignored due to path filters (1)

upcoming-release-notes/4468.md is excluded by !**/*.md

📒 Files selected for processing (1)

packages/loot-core/src/server/budget/cleanup-template.ts (2 hunks)

🧰 Additional context used

🪛 GitHub Check: lint

packages/loot-core/src/server/budget/cleanup-template.ts

[warning] 354-354:
Expected '===' and instead saw '=='

🪛 GitHub Actions: Test

packages/loot-core/src/server/budget/cleanup-template.ts

[warning] 354-354: ESLint: Expected '===' and instead saw '==' (eqeqeq)

⏰ Context from checks skipped due to timeout of 90000ms (5)

GitHub Check: Functional
GitHub Check: Visual regression
GitHub Check: build (macos-latest)
GitHub Check: build (windows-latest)
GitHub Check: build (ubuntu-latest)

🔇 Additional comments (1)

packages/loot-core/src/server/budget/cleanup-template.ts (1)

287-287: Logical improvement to warning condition

This change ensures that a warning is only shown when the budget is truly unavailable (negative), not when it's exactly zero (balanced). This aligns perfectly with the PR objective to avoid unnecessary warnings on clean budgets.

packages/loot-core/src/server/budget/cleanup-template.ts

matt-fidd

LGTM

change condition

eb9a440

actual-github-bot bot changed the title ~~fix #4445~~ [WIP] fix #4445 Feb 27, 2025

actual-github-bot bot added the 🚧 WIP label Feb 27, 2025

youngcw added 2 commits February 27, 2025 08:49

new message

7fea8d8

fix

ac7e446

youngcw added this to the v25.3.0 milestone Feb 27, 2025

youngcw changed the title ~~[WIP] fix #4445~~ fix #4445 Feb 27, 2025

actual-github-bot bot added 🔍 Ready for review and removed 🚧 WIP labels Feb 27, 2025

coderabbitai bot reviewed Feb 27, 2025

View reviewed changes

packages/loot-core/src/server/budget/cleanup-template.ts Outdated Show resolved Hide resolved

lint

018a93c

matt-fidd approved these changes Feb 27, 2025

View reviewed changes

actual-github-bot bot added ✅ Approved and removed 🔍 Ready for review labels Feb 27, 2025

youngcw merged commit a7cde1f into master Feb 27, 2025
21 checks passed

youngcw deleted the youncw/fix_cleanup_warning branch February 27, 2025 17:06

actual-github-bot bot added ✨ Merged and removed ✅ Approved labels Feb 27, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix #4445 #4468

fix #4445 #4468

youngcw commented Feb 27, 2025 •

edited

Loading

netlify bot commented Feb 27, 2025 •

edited

Loading

github-actions bot commented Feb 27, 2025 •

edited

Loading

github-actions bot commented Feb 27, 2025 •

edited

Loading

coderabbitai bot commented Feb 27, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

coderabbitai bot left a comment

matt-fidd left a comment

fix #4445 #4468

fix #4445 #4468

Conversation

youngcw commented Feb 27, 2025 • edited Loading

netlify bot commented Feb 27, 2025 • edited Loading

✅ Deploy Preview for actualbudget ready!

github-actions bot commented Feb 27, 2025 • edited Loading

Bundle Stats — desktop-client

github-actions bot commented Feb 27, 2025 • edited Loading

Bundle Stats — loot-core

coderabbitai bot commented Feb 27, 2025 • edited Loading

Walkthrough

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

matt-fidd left a comment

Choose a reason for hiding this comment

youngcw commented Feb 27, 2025 •

edited

Loading

netlify bot commented Feb 27, 2025 •

edited

Loading

github-actions bot commented Feb 27, 2025 •

edited

Loading

github-actions bot commented Feb 27, 2025 •

edited

Loading

coderabbitai bot commented Feb 27, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)