Copy budget files to succeed even if cleanup fails & adding retries #4507

MikesGlitch · 2025-03-02T19:24:47Z

When the user tries to move their budget directory there's a chance the directory will fail if the permissions aren't right or the files are locked.

The current issue is that if it fails it leaves the users budget files in one place, but the app still references the old file location. So their budget files appear to be gone.

The fix is to allow the budget directory to succeed if the budget files moved, which allows the app to set the new budget directory. To mitigate file locking I've added retries.

netlify · 2025-03-02T19:25:06Z

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	`0941c81`
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/67c4cc3c82166b0008ce08d4
😎 Deploy Preview	https://deploy-preview-4507.demo.actualbudget.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions · 2025-03-02T19:26:17Z

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
18	7.07 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
static/js/en-GB.js	96.59 kB	0%
static/js/en.js	103.63 kB	0%
static/js/de.js	112.69 kB	0%
static/js/workbox-window.prod.es5.js	5.69 kB	0%
static/js/indexeddb-main-thread-worker-e59fee74.js	13.5 kB	0%
static/js/resize-observer.js	18.37 kB	0%
static/js/nl.js	95.56 kB	0%
static/js/es.js	58.26 kB	0%
static/js/BackgroundImage.js	122.29 kB	0%
static/js/pt-BR.js	110.57 kB	0%
static/js/fr.js	100.72 kB	0%
static/js/uk.js	111.11 kB	0%
static/js/useAccountPreviewTransactions.js	1.69 kB	0%
static/js/AppliedFilters.js	10.8 kB	0%
static/js/wide.js	102.9 kB	0%
static/js/narrow.js	86.26 kB	0%
static/js/ReportRouter.js	1.59 MB	0%
static/js/index.js	4.36 MB	0%

github-actions · 2025-03-02T19:26:18Z

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
1	1.34 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
kcab.worker.js	1.34 MB	0%

packages/desktop-electron/index.ts

coderabbitai · 2025-03-02T19:33:14Z

Walkthrough

The changes modify the move-budget-directory IPC handler in the packages/desktop-electron/index.ts file. A new preserveTimestamps option is added to the copy function call to ensure file timestamps are retained. Additionally, rather than immediately removing the currentBudgetDirectory using a single await remove(currentBudgetDirectory); call, a try-catch block is introduced to handle potential errors during removal. If the removal fails, the error is caught and logged, allowing the process to continue without interruption. This adjustment improves the robustness of the directory move operation by avoiding a hard failure when the directory cannot be deleted. The package.json file is also updated to change the version of the fs-extra dependency from ^11.2.0 to ^11.3.0.

Possibly related PRs

Move file settings to the file management area #3584: The changes in the main PR, which modify the IPC handler for moving budget directories, are related to the retrieved PR that introduces a new method for moving budget directories within the application's context, as both involve similar functionality for managing budget directories.

Suggested labels

sparkles: Merged

Suggested reviewers

youngcw
joel-jeremy

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6d5a316 and 0941c81.

📒 Files selected for processing (1)

packages/desktop-electron/index.ts (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

packages/desktop-electron/index.ts

⏰ Context from checks skipped due to timeout of 90000ms (5)

GitHub Check: build (macos-latest)
GitHub Check: build (windows-latest)
GitHub Check: build (ubuntu-latest)
GitHub Check: Wait for Netlify build to finish
GitHub Check: Analyze

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

youngcw · 2025-03-03T16:35:01Z

Is this for #4286?

MikesGlitch · 2025-03-03T18:46:12Z

Is this for #4286?

This one's different. It's for the

allowing copy budget files to succeed even if cleanup fails

9a472b2

actual-github-bot bot added the 🚧 WIP label Mar 2, 2025

release notes

fe49e91

MikesGlitch marked this pull request as ready for review March 2, 2025 19:31

actual-github-bot bot added 🔍 Ready for review and removed 🚧 WIP labels Mar 2, 2025

MikesGlitch commented Mar 2, 2025

View reviewed changes

packages/desktop-electron/index.ts Show resolved Hide resolved

MikesGlitch changed the title ~~allowing copy budget files to succeed even if cleanup fails~~ Copy budget files to succeed even if cleanup fails Mar 2, 2025

MikesGlitch added 2 commits March 2, 2025 19:52

updating fs-extra

98739b0

retries in for removing dir

4cdef53

MikesGlitch changed the title ~~Copy budget files to succeed even if cleanup fails~~ Copy budget files to succeed even if cleanup fails & adding retries Mar 2, 2025

MikesGlitch added 2 commits March 2, 2025 21:09

better retry defaults

6d5a316

defaults

0941c81

matt-fidd approved these changes Mar 3, 2025

View reviewed changes

actual-github-bot bot added ✅ Approved and removed 🔍 Ready for review labels Mar 3, 2025

MikesGlitch merged commit b74175e into actualbudget:master Mar 3, 2025
21 checks passed

actual-github-bot bot added ✨ Merged and removed ✅ Approved labels Mar 3, 2025

MikesGlitch deleted the fix/move-files-should-be-successful-if-files-moved branch March 3, 2025 18:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Copy budget files to succeed even if cleanup fails & adding retries #4507

Copy budget files to succeed even if cleanup fails & adding retries #4507

MikesGlitch commented Mar 2, 2025 •

edited

Loading

netlify bot commented Mar 2, 2025 •

edited

Loading

github-actions bot commented Mar 2, 2025 •

edited

Loading

github-actions bot commented Mar 2, 2025 •

edited

Loading

coderabbitai bot commented Mar 2, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

youngcw commented Mar 3, 2025

MikesGlitch commented Mar 3, 2025

Copy budget files to succeed even if cleanup fails & adding retries #4507

Copy budget files to succeed even if cleanup fails & adding retries #4507

Conversation

MikesGlitch commented Mar 2, 2025 • edited Loading

netlify bot commented Mar 2, 2025 • edited Loading

✅ Deploy Preview for actualbudget ready!

github-actions bot commented Mar 2, 2025 • edited Loading

Bundle Stats — desktop-client

github-actions bot commented Mar 2, 2025 • edited Loading

Bundle Stats — loot-core

coderabbitai bot commented Mar 2, 2025 • edited Loading

Walkthrough

Possibly related PRs

Suggested labels

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

youngcw commented Mar 3, 2025

MikesGlitch commented Mar 3, 2025

MikesGlitch commented Mar 2, 2025 •

edited

Loading

netlify bot commented Mar 2, 2025 •

edited

Loading

github-actions bot commented Mar 2, 2025 •

edited

Loading

github-actions bot commented Mar 2, 2025 •

edited

Loading

coderabbitai bot commented Mar 2, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)