Copy budget files to succeed even if cleanup fails & adding retries

packages/desktop-electron/index.ts

@@ -554,14 +554,25 @@ ipcMain.handle(
 
       await copy(currentBudgetDirectory, newDirectory, {
         overwrite: true,
+        preserveTimestamps: true,
       });
-      await remove(currentBudgetDirectory);
     } catch (error) {
       logMessage(
         'error',
         `There was an error moving your directory:  ${error}`,
       );
       throw error;
     }
+
+    try {
+      await remove(currentBudgetDirectory);
+    } catch (error) {
+      // Fail silently. The move worked, but the old directory wasn't cleaned up - most likely a permission issue.
+      // This call needs to succeed to allow the user to continue using the app with the files in the new location.
+      logMessage(
+        'error',
+        `There was an error removing the old directory: ${error}`,
+      );
+    }
   },
 );

upcoming-release-notes/4507.md

@@ -0,0 +1,6 @@
+---
+category: Bugfix
+authors: [MikesGlitch]
+---
+
+Allow desktop app to move budget files even when cleanup tasks fail